You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/18 14:42:00 UTC

[GitHub] [flink-statefun-playground] tzulitai opened a new pull request #3: [FLINK-21862] Add a Java SDK Showcase tutorial

tzulitai opened a new pull request #3:
URL: https://github.com/apache/flink-statefun-playground/pull/3


   This Java project is intended for new StateFun users that would like to start implementing their StateFun application functions using Java (or any other JVM language).
   
   The tutorial is streamlined and split into a few parts which we recommend users to go through a specific order.
   
   Each part is demonstrated with some code snippets plus Javadocs and comments to guide users through the SDK fundamentals.
   
   Users can import this project into an IDE (we suggest IntelliJ IDEA) to ease navigation through the classes and pointers throughout the tutorial.
   
   Please see the README.md on more details of how this showcase tutorial is lay out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] tzulitai closed pull request #3: [FLINK-21862] Add a Java SDK Showcase tutorial

Posted by GitBox <gi...@apache.org>.
tzulitai closed pull request #3:
URL: https://github.com/apache/flink-statefun-playground/pull/3


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] tzulitai commented on a change in pull request #3: [FLINK-21862] Add a Java SDK Showcase tutorial

Posted by GitBox <gi...@apache.org>.
tzulitai commented on a change in pull request #3:
URL: https://github.com/apache/flink-statefun-playground/pull/3#discussion_r597341146



##########
File path: java/showcase/pom.xml
##########
@@ -0,0 +1,115 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+  http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <groupId>org.apache.flink</groupId>
+    <artifactId>statefun-java-showcase</artifactId>
+    <version>3.0-SNAPSHOT</version>
+    <packaging>jar</packaging>
+
+    <properties>
+        <statefun.version>2.3-SNAPSHOT</statefun.version>
+        <maven.compiler.source>8</maven.compiler.source>
+        <maven.compiler.target>8</maven.compiler.target>
+    </properties>
+
+    <dependencies>
+        <!-- StateFun Java SDK -->
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>statefun-sdk-java</artifactId>
+            <version>${statefun.version}</version>
+        </dependency>
+
+        <!-- For custom type serialization (JSON and Protobuf) -->
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-databind</artifactId>
+            <version>2.12.2</version>
+        </dependency>
+
+        <dependency>
+            <groupId>com.google.protobuf</groupId>
+            <artifactId>protobuf-java</artifactId>
+            <version>3.11.4</version>
+        </dependency>
+
+        <!-- Undertow web server -->
+        <dependency>
+            <groupId>io.undertow</groupId>
+            <artifactId>undertow-servlet</artifactId>

Review comment:
       Updated to use core

##########
File path: java/showcase/src/main/java/org/apache/flink/statefun/playground/java/showcase/part1/types/my-protobuf-type.proto
##########
@@ -0,0 +1,33 @@
+/*

Review comment:
       Moved to src/main/protobuf




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] igalshilman commented on a change in pull request #3: [FLINK-21862] Add a Java SDK Showcase tutorial

Posted by GitBox <gi...@apache.org>.
igalshilman commented on a change in pull request #3:
URL: https://github.com/apache/flink-statefun-playground/pull/3#discussion_r596951471



##########
File path: java/showcase/pom.xml
##########
@@ -0,0 +1,115 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+  http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <groupId>org.apache.flink</groupId>
+    <artifactId>statefun-java-showcase</artifactId>
+    <version>3.0-SNAPSHOT</version>
+    <packaging>jar</packaging>
+
+    <properties>
+        <statefun.version>2.3-SNAPSHOT</statefun.version>
+        <maven.compiler.source>8</maven.compiler.source>
+        <maven.compiler.target>8</maven.compiler.target>
+    </properties>
+
+    <dependencies>
+        <!-- StateFun Java SDK -->
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>statefun-sdk-java</artifactId>
+            <version>${statefun.version}</version>
+        </dependency>
+
+        <!-- For custom type serialization (JSON and Protobuf) -->
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-databind</artifactId>
+            <version>2.12.2</version>
+        </dependency>
+
+        <dependency>
+            <groupId>com.google.protobuf</groupId>
+            <artifactId>protobuf-java</artifactId>
+            <version>3.11.4</version>
+        </dependency>
+
+        <!-- Undertow web server -->
+        <dependency>
+            <groupId>io.undertow</groupId>
+            <artifactId>undertow-servlet</artifactId>

Review comment:
       Is this is the correct artifact? does `undertow-core` suffies ?
   
   

##########
File path: java/showcase/src/main/java/org/apache/flink/statefun/playground/java/showcase/part1/types/my-protobuf-type.proto
##########
@@ -0,0 +1,33 @@
+/*

Review comment:
       Is this file in the correct place?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] asfgit closed pull request #3: [FLINK-21862] Add a Java SDK Showcase tutorial

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3:
URL: https://github.com/apache/flink-statefun-playground/pull/3


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] tzulitai commented on pull request #3: [FLINK-21862] Add a Java SDK Showcase tutorial

Posted by GitBox <gi...@apache.org>.
tzulitai commented on pull request #3:
URL: https://github.com/apache/flink-statefun-playground/pull/3#issuecomment-802432567


   Thanks for the review, merging this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org