You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/11 13:31:20 UTC
[GitHub] zjffdu commented on a change in pull request #7459: [FLINK-11300]
Make MetricFetcher update interval configurable
zjffdu commented on a change in pull request #7459: [FLINK-11300] Make MetricFetcher update interval configurable
URL: https://github.com/apache/flink/pull/7459#discussion_r247115542
##########
File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
##########
@@ -193,7 +193,12 @@ public WebRuntimeMonitor(
} else {
sslFactory = null;
}
- metricFetcher = new MetricFetcher(retriever, queryServiceRetriever, scheduledExecutor, timeout);
+ metricFetcher = new MetricFetcher(
+ retriever,
+ queryServiceRetriever,
+ scheduledExecutor,
+ timeout,
+ WebOptions.METRIC_FETCHER_UPDATE_INTERVAL.defaultValue());
Review comment:
Shouldn't it be the configured value instead of default value ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services