You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2008/09/05 19:20:44 UTC
[jira] Created: (HADOOP-4083) change new config attribute
queue.name to mapred.job.queue.name
change new config attribute queue.name to mapred.job.queue.name
---------------------------------------------------------------
Key: HADOOP-4083
URL: https://issues.apache.org/jira/browse/HADOOP-4083
Project: Hadoop Core
Issue Type: Improvement
Reporter: Owen O'Malley
The new queue.name attribute should really be prefixed by mapred.job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4083) change new config attribute
queue.name to mapred.job.queue.name
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-4083:
-------------------------------------
Attachment: HADOOP-4083.patch
Sigh. Attaching the right patch file.
> change new config attribute queue.name to mapred.job.queue.name
> ---------------------------------------------------------------
>
> Key: HADOOP-4083
> URL: https://issues.apache.org/jira/browse/HADOOP-4083
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Owen O'Malley
> Assignee: Hemanth Yamijala
> Fix For: 0.19.0
>
> Attachments: HADOOP-4036.patch, HADOOP-4083.patch
>
>
> The new queue.name attribute should really be prefixed by mapred.job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4083) change new config attribute
queue.name to mapred.job.queue.name
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-4083:
-------------------------------------
Status: Patch Available (was: Open)
Running through Hudson. The patch has no test cases because it is only a change in a configuration variable name.
> change new config attribute queue.name to mapred.job.queue.name
> ---------------------------------------------------------------
>
> Key: HADOOP-4083
> URL: https://issues.apache.org/jira/browse/HADOOP-4083
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Owen O'Malley
> Assignee: Hemanth Yamijala
> Fix For: 0.19.0
>
> Attachments: HADOOP-4036.patch, HADOOP-4083.patch
>
>
> The new queue.name attribute should really be prefixed by mapred.job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4083) change new config attribute
queue.name to mapred.job.queue.name
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-4083:
-------------------------------------
Component/s: mapred
Affects Version/s: 0.19.0
Fix Version/s: 0.19.0
Assignee: Hemanth Yamijala
> change new config attribute queue.name to mapred.job.queue.name
> ---------------------------------------------------------------
>
> Key: HADOOP-4083
> URL: https://issues.apache.org/jira/browse/HADOOP-4083
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Owen O'Malley
> Assignee: Hemanth Yamijala
> Fix For: 0.19.0
>
>
> The new queue.name attribute should really be prefixed by mapred.job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4083) change new config attribute
queue.name to mapred.job.queue.name
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-4083:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Hemanth!
> change new config attribute queue.name to mapred.job.queue.name
> ---------------------------------------------------------------
>
> Key: HADOOP-4083
> URL: https://issues.apache.org/jira/browse/HADOOP-4083
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Owen O'Malley
> Assignee: Hemanth Yamijala
> Fix For: 0.19.0
>
> Attachments: HADOOP-4036.patch, HADOOP-4083.patch
>
>
> The new queue.name attribute should really be prefixed by mapred.job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4083) change new config attribute
queue.name to mapred.job.queue.name
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632348#action_12632348 ]
Hadoop QA commented on HADOOP-4083:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390358/HADOOP-4083.patch
against trunk revision 696707.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3305/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3305/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3305/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3305/console
This message is automatically generated.
> change new config attribute queue.name to mapred.job.queue.name
> ---------------------------------------------------------------
>
> Key: HADOOP-4083
> URL: https://issues.apache.org/jira/browse/HADOOP-4083
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Owen O'Malley
> Assignee: Hemanth Yamijala
> Fix For: 0.19.0
>
> Attachments: HADOOP-4036.patch, HADOOP-4083.patch
>
>
> The new queue.name attribute should really be prefixed by mapred.job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4083) change new config attribute
queue.name to mapred.job.queue.name
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632228#action_12632228 ]
Hemanth Yamijala commented on HADOOP-4083:
------------------------------------------
Results of test-patch that I ran on my machine:
[exec] -1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
As explained above, there are no test cases because it is only a config name change.
Also ran ant test-core and test-contrib, and all tests passed.
> change new config attribute queue.name to mapred.job.queue.name
> ---------------------------------------------------------------
>
> Key: HADOOP-4083
> URL: https://issues.apache.org/jira/browse/HADOOP-4083
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Owen O'Malley
> Assignee: Hemanth Yamijala
> Fix For: 0.19.0
>
> Attachments: HADOOP-4036.patch, HADOOP-4083.patch
>
>
> The new queue.name attribute should really be prefixed by mapred.job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4083) change new config attribute
queue.name to mapred.job.queue.name
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633310#action_12633310 ]
Hudson commented on HADOOP-4083:
--------------------------------
Integrated in Hadoop-trunk #611 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/611/])
> change new config attribute queue.name to mapred.job.queue.name
> ---------------------------------------------------------------
>
> Key: HADOOP-4083
> URL: https://issues.apache.org/jira/browse/HADOOP-4083
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Owen O'Malley
> Assignee: Hemanth Yamijala
> Fix For: 0.19.0
>
> Attachments: HADOOP-4036.patch, HADOOP-4083.patch
>
>
> The new queue.name attribute should really be prefixed by mapred.job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4083) change new config attribute
queue.name to mapred.job.queue.name
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-4083:
-------------------------------------
Attachment: HADOOP-4036.patch
Attaching patch with a trivial change. I am running test-patch and tests to make sure things are passing.
This changes code in FairScheduler. In the {{PoolManager}} class, the property for the pool name was being used as {{queue.name}}. I have changed it there to {{mapred.job.queue.name}}. I think the change is correct, but if Matei can verify once it will be great !
> change new config attribute queue.name to mapred.job.queue.name
> ---------------------------------------------------------------
>
> Key: HADOOP-4083
> URL: https://issues.apache.org/jira/browse/HADOOP-4083
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Owen O'Malley
> Assignee: Hemanth Yamijala
> Fix For: 0.19.0
>
> Attachments: HADOOP-4036.patch
>
>
> The new queue.name attribute should really be prefixed by mapred.job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.