[GitHub] [airflow] eladkal commented on a diff in pull request #31855: Add Redis task handler

["eladkal (via GitHub)" <gi...@apache.org>]

eladkal commented on code in PR #31855:
URL: https://github.com/apache/airflow/pull/31855#discussion_r1244254067


##########
airflow/utils/log/file_task_handler.py:
##########
@@ -147,7 +147,7 @@ class FileTaskHandler(logging.Handler):
 
     def __init__(self, base_log_folder: str, filename_template: str | None = None):
         super().__init__()
-        self.handler: logging.FileHandler | None = None
+        self.handler: logging.Handler | None = None

Review Comment:
   If this specific change is not tightly coupled to this PR I would suggest to do it in a separated PR.
   this is because utils/log goes to core release cycle while the other files goes to provider release cycle.
   @michalc Is it possible to seperate?



##########
airflow/utils/log/file_task_handler.py:
##########
@@ -147,7 +147,7 @@ class FileTaskHandler(logging.Handler):
 
     def __init__(self, base_log_folder: str, filename_template: str | None = None):
         super().__init__()
-        self.handler: logging.FileHandler | None = None
+        self.handler: logging.Handler | None = None

Review Comment:
   If this specific change is not tightly coupled to this PR I would suggest to do it in a separated PR.
   this is because utils/log goes to core release cycle while the other files goes to provider release cycle.
   @michalc Is it possible to separate?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org