You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/06/15 14:59:34 UTC
[GitHub] [camel-quarkus] valdar opened a new pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
valdar opened a new pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786
[X] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes: https://github.com/apache/camel-quarkus/issues/2733
[X] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[X] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[X] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[X] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[X] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] valdar commented on a change in pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
valdar commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r652180844
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the following option. The kamelet to pre-load can be listed using the `quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
+
+A set of pre-made Kamelets can be found on the https://camel.apache.org/camel-kamelets/latest[Kamelet Catalog].
+To use the Kamelet from the catalog you either need to copy them on your project in the classpath location defined by the `quarkus.camel.kamelet.location` property, or you can add the `camel-quarkus-kamelets-catalog` artifact to your `pom.xml`:
+
+[source,xml]
+----
+<dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-kamelets-catalog</artifactId>
+</dependency>
+----
+
+This artifact makes all the kamelets available in the catalog available to Camel Quarkus for build time processing, the artefact is not part of the runtime classpath.
Review comment:
I have tried to better explain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r651880427
##########
File path: extensions/kamelet/deployment/pom.xml
##########
@@ -38,6 +38,14 @@
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-kamelet</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-yaml</artifactId>
Review comment:
is this needed ?
##########
File path: extensions/kamelet/deployment/pom.xml
##########
@@ -38,6 +38,14 @@
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-kamelet</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-yaml</artifactId>
Review comment:
is this dependency needed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] valdar commented on a change in pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
valdar commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r652001022
##########
File path: docs/modules/ROOT/pages/reference/extensions/kamelet.adoc
##########
@@ -37,3 +37,46 @@ Or add the coordinates to your existing project:
----
Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
+
+== Usage
+
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the following two options. The kamelet to pre-load can be listed using the `quarkus.camel.kamelet.names` property.
Review comment:
Changed to reflect real option name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r651955854
##########
File path: docs/modules/ROOT/pages/reference/extensions/kamelet.adoc
##########
@@ -37,3 +37,46 @@ Or add the coordinates to your existing project:
----
Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
+
+== Usage
+
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the following two options. The kamelet to pre-load can be listed using the `quarkus.camel.kamelet.names` property.
Review comment:
Are there two options? Or just the one config property?
##########
File path: docs/modules/ROOT/pages/contributor-guide/index.adoc
##########
@@ -1,4 +1,4 @@
-[[contributor-guide]]
+ntributor-guide]]
Review comment:
I guess this was an unintended change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r652481412
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the following option. The kamelet to pre-load can be listed using the `quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
+
+A set of pre-made Kamelets can be found on the https://camel.apache.org/camel-kamelets/latest[Kamelet Catalog].
+To use the Kamelet from the catalog you either need to copy them on your project in the classpath location defined by the `quarkus.camel.kamelet.location` property, or you can add the `camel-quarkus-kamelets-catalog` artifact to your `pom.xml`:
+
+[source,xml]
+----
+<dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-kamelets-catalog</artifactId>
+</dependency>
+----
+
+This artifact makes all the kamelets available in the catalog available to Camel Quarkus for build time processing, the artefact is not part of the runtime classpath.
Review comment:
Much better, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] valdar commented on pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
valdar commented on pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#issuecomment-861863467
@ppalaga thanks for the review. I have tried to improve documentation clearness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] valdar commented on pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
valdar commented on pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#issuecomment-862210998
They seems to be mostly related to `solr` component?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] valdar commented on a change in pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
valdar commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r652181347
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the following option. The kamelet to pre-load can be listed using the `quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
+
+A set of pre-made Kamelets can be found on the https://camel.apache.org/camel-kamelets/latest[Kamelet Catalog].
+To use the Kamelet from the catalog you either need to copy them on your project in the classpath location defined by the `quarkus.camel.kamelet.location` property, or you can add the `camel-quarkus-kamelets-catalog` artifact to your `pom.xml`:
Review comment:
`quarkus.camel.kamelet.location` was a leftover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r651915531
##########
File path: extensions/kamelet/deployment/src/main/java/org/apache/camel/quarkus/component/kamelet/deployment/KameletProcessor.java
##########
@@ -16,15 +16,90 @@
*/
package org.apache.camel.quarkus.component.kamelet.deployment;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.List;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
import io.quarkus.deployment.builditem.FeatureBuildItem;
+import org.apache.camel.CamelContext;
+import org.apache.camel.ExtendedCamelContext;
+import org.apache.camel.Ordered;
+import org.apache.camel.RoutesBuilder;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.impl.DefaultCamelContext;
+import org.apache.camel.model.RouteTemplateDefinition;
+import org.apache.camel.quarkus.component.kamelet.KameletConfiguration;
+import org.apache.camel.quarkus.component.kamelet.KameletRecorder;
+import org.apache.camel.quarkus.core.deployment.spi.CamelContextCustomizerBuildItem;
+import org.apache.camel.spi.Resource;
class KameletProcessor {
-
private static final String FEATURE = "camel-kamelet";
@BuildStep
FeatureBuildItem feature() {
return new FeatureBuildItem(FEATURE);
}
+
+ @BuildStep
+ KameletResolverBuildItem defaultResolver() {
+ return new KameletResolverBuildItem(new KameletResolver() {
+ @Override
+ public Optional<Resource> resolve(String id, CamelContext context) throws Exception {
+ ExtendedCamelContext ecc = context.adapt(ExtendedCamelContext.class);
+ return Optional.ofNullable(
+ ecc.getResourceLoader().resolveResource("/kamelets/" + id + ".kamelet.yaml"));
+ }
+ });
+ }
+
+ @Record(ExecutionTime.STATIC_INIT)
+ @BuildStep
+ CamelContextCustomizerBuildItem configureTemplates(
+ List<KameletResolverBuildItem> resolvers,
+ KameletConfiguration configuration,
+ KameletRecorder recorder) throws Exception {
+
+ List<RouteTemplateDefinition> definitions = new ArrayList<>();
+ List<KameletResolver> kameletResolvers = resolvers.stream()
+ .map(KameletResolverBuildItem::getResolver)
+ .sorted(Comparator.comparingInt(Ordered::getOrder))
+ .collect(Collectors.toList());
+
+ CamelContext context = new DefaultCamelContext();
+ ExtendedCamelContext ecc = context.adapt(ExtendedCamelContext.class);
+
+ for (String name : configuration.names.orElse(Collections.emptyList())) {
+ for (KameletResolver resolver : kameletResolvers) {
+ final Optional<Resource> resource = resolver.resolve(name, ecc);
+ if (!resource.isPresent()) {
+ continue;
+ }
+
+ Collection<RoutesBuilder> rbs = ecc.getRoutesLoader().findRoutesBuilders(resource.get());
+ for (RoutesBuilder rb : rbs) {
+ RouteBuilder routeBuilder = (RouteBuilder) rb;
+ routeBuilder.configure();
+ if (routeBuilder.getRouteTemplateCollection().getRouteTemplates().size() != 1) {
+ throw new IllegalStateException(
+ "A kamelet is not supposed to create more than one route ("
Review comment:
maybe we need a better message if no route templates have been found
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] valdar commented on a change in pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
valdar commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r652180660
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the following option. The kamelet to pre-load can be listed using the `quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
Review comment:
this was a leftover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] valdar commented on a change in pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
valdar commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r652181211
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the following option. The kamelet to pre-load can be listed using the `quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
+
+A set of pre-made Kamelets can be found on the https://camel.apache.org/camel-kamelets/latest[Kamelet Catalog].
+To use the Kamelet from the catalog you either need to copy them on your project in the classpath location defined by the `quarkus.camel.kamelet.location` property, or you can add the `camel-quarkus-kamelets-catalog` artifact to your `pom.xml`:
Review comment:
I have tried to better explain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#issuecomment-862231192
Solr and MongoDB are known to be flaky but there are more tests failing here, which I find truly strange. I added https://github.com/apache/camel-quarkus/pull/2795 for MongoDB.
Is there any practical reason for having two commits here? Would you mind squashing if not? - that will restart the CI. Otherwise I can restart manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] valdar commented on a change in pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
valdar commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r652000693
##########
File path: docs/modules/ROOT/pages/contributor-guide/index.adoc
##########
@@ -1,4 +1,4 @@
-[[contributor-guide]]
+ntributor-guide]]
Review comment:
It was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r652104042
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the following option. The kamelet to pre-load can be listed using the `quarkus.camel.kamelet.identifiers` property.
Review comment:
```suggestion
This extension allows to pre-load a set of Kamelets at build time using the `quarkus.camel.kamelet.identifiers` property.
```
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the following option. The kamelet to pre-load can be listed using the `quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
+
+A set of pre-made Kamelets can be found on the https://camel.apache.org/camel-kamelets/latest[Kamelet Catalog].
+To use the Kamelet from the catalog you either need to copy them on your project in the classpath location defined by the `quarkus.camel.kamelet.location` property, or you can add the `camel-quarkus-kamelets-catalog` artifact to your `pom.xml`:
Review comment:
> you either need to copy them
What is "them"? What kind of files are the end users supposed to copy from where?
##########
File path: extensions/kamelet/runtime/src/main/java/org/apache/camel/quarkus/component/kamelet/KameletConfiguration.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.kamelet;
+
+import java.util.List;
+import java.util.Optional;
+
+import io.quarkus.runtime.annotations.ConfigItem;
+import io.quarkus.runtime.annotations.ConfigPhase;
+import io.quarkus.runtime.annotations.ConfigRoot;
+
+@ConfigRoot(name = "camel.kamelet", phase = ConfigPhase.BUILD_TIME)
+public class KameletConfiguration {
+ /**
+ * List of kamelets identifiers to pre-load at build time.
+ *
+ * <p/>
Review comment:
```suggestion
* <p>
```
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the following option. The kamelet to pre-load can be listed using the `quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
+
+A set of pre-made Kamelets can be found on the https://camel.apache.org/camel-kamelets/latest[Kamelet Catalog].
+To use the Kamelet from the catalog you either need to copy them on your project in the classpath location defined by the `quarkus.camel.kamelet.location` property, or you can add the `camel-quarkus-kamelets-catalog` artifact to your `pom.xml`:
+
+[source,xml]
+----
+<dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-kamelets-catalog</artifactId>
+</dependency>
+----
+
+This artifact makes all the kamelets available in the catalog available to Camel Quarkus for build time processing, the artefact is not part of the runtime classpath.
Review comment:
```suggestion
This artifact makes all the kamelets available in the catalog available to Camel Quarkus for build time processing, the artifact is not part of the runtime classpath.
```
> the artifact is not part of the runtime classpath.
How is that meant? It is there as a dependency of the user app, but it is not there at runtime of the user app? Could you please add a sentence explaining how is that possible?
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the following option. The kamelet to pre-load can be listed using the `quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
Review comment:
What does not exist? If there is something left to do, please file a follow up issue and paste the link here.
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the following option. The kamelet to pre-load can be listed using the `quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
+
+A set of pre-made Kamelets can be found on the https://camel.apache.org/camel-kamelets/latest[Kamelet Catalog].
+To use the Kamelet from the catalog you either need to copy them on your project in the classpath location defined by the `quarkus.camel.kamelet.location` property, or you can add the `camel-quarkus-kamelets-catalog` artifact to your `pom.xml`:
Review comment:
I do not see `quarkus.camel.kamelet.location` anywhere in the code. Am I overseeing it or that's the missing part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#issuecomment-862204207
The test failures are strange. Can you think of any explanation, @jamesnetherton?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] valdar commented on a change in pull request #2786: fix Issue/2733 : Native support for kamelet.yaml discovery
Posted by GitBox <gi...@apache.org>.
valdar commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r651885735
##########
File path: extensions/kamelet/deployment/pom.xml
##########
@@ -38,6 +38,14 @@
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-kamelet</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-yaml</artifactId>
Review comment:
most probably not tnx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org