You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2015/11/10 21:29:05 UTC
[GitHub] storm pull request: STORM-1197: Migrate Travis-CI to container-bas...
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/874
STORM-1197: Migrate Travis-CI to container-based builds.
http://docs.travis-ci.com/user/migrating-from-legacy/
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-1197
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/874.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #874
----
commit a0e734727d2335bb0e7a12f8ada8ca07f4908ded
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2015-11-10T20:27:21Z
Adding setting to travis.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1197: Migrate Travis-CI to container-bas...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/874#issuecomment-155838704
@HeartSaVioR
Yes, I remembered that the external parts I split off the storm-core build are dependent on the storm-core jar, so they must be done after storm-core. There isn't any benefit to doing the external, etc. in parallel with each other either, since they are so small that the startup cost overwhelms the parallelization benefit.
The caching is still valid, but it only shaves a few seconds off.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1197: Migrate Travis-CI to container-bas...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/874#issuecomment-155609477
@HeartSaVioR
There. I shaved a little more than 5 minutes off the build time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1197: Migrate Travis-CI to container-bas...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/874
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1197: Migrate Travis-CI to container-bas...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/874#issuecomment-155632759
@knusbaum
Hey, I see the benefit of splitting build matrix, since it seems faster than current.
If ```legacy + splitting build matrix``` doesn't work, I'd like to vote +1 to ```container based + splitting build matrix```.
I'd like to see reason of closing this PR. Did you see the disadvantage of splitting build matrix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1197: Migrate Travis-CI to container-bas...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/874#issuecomment-155621269
@knusbaum
Container based build doesn't save build time.
Seems like splitting build matrix saves build time, so I'd like to see it applied to legacy.
Btw, container based build is triggered faster than legacy, so container based build takes advantage when build time is small enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1197: Migrate Travis-CI to container-bas...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/874#issuecomment-155569842
@knusbaum
It makes build slower than current now. Please refer #761 for more info.
Btw, if it is more stable than legacy (I mean less random test failures) I'll definitely vote +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---