You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/05/06 12:53:29 UTC
[GitHub] [libcloud] pgajdos opened a new issue, #1684: use unittest.mock instead of mock
pgajdos opened a new issue, #1684:
URL: https://github.com/apache/libcloud/issues/1684
Could you please consider to use unittest.mock, as a fallback at least?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on issue #1684: use unittest.mock instead of mock
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1684:
URL: https://github.com/apache/libcloud/issues/1684#issuecomment-1122900409
Thanks for the additional context.
If it simplifies the packaging and we don't loose any functionality, I'm fine with replacing it with stdlib mock module.
Not sure how much it really simplifies the packaging though, since we still have a lot of other test dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on issue #1684: use unittest.mock instead of mock
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1684:
URL: https://github.com/apache/libcloud/issues/1684#issuecomment-1120012194
Can you please provide some reasoning on this feature request? ``mock`` is a tests only dependency so it shouldn't be a problem if we depend on it (since we already depend on other libraries for tests as well).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on issue #1684: use unittest.mock instead of mock
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1684:
URL: https://github.com/apache/libcloud/issues/1684#issuecomment-1122921618
@pgajdos On a somewhat related note, I see there are some other patches upstream (https://build.opensuse.org/package/view_file/home:pgajdos:python/python-apache-libcloud/ec2_create_node.patch?expand=1, https://build.opensuse.org/package/view_file/home:pgajdos:python/python-apache-libcloud/gce_image_projects.patch?expand=1, https://build.opensuse.org/package/view_file/home:pgajdos:python/python-apache-libcloud/skip-some-tests-for-older-paramiko-versions.patch?expand=1).
All of those patches seem reasonable and we would be happy to accept them upstream if they are contributed to the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on issue #1684: use unittest.mock instead of mock
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1684:
URL: https://github.com/apache/libcloud/issues/1684#issuecomment-1122917850
#1691 should solve this. Thanks for reporting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami closed issue #1684: use unittest.mock instead of mock
Posted by GitBox <gi...@apache.org>.
Kami closed issue #1684: use unittest.mock instead of mock
URL: https://github.com/apache/libcloud/issues/1684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] pgajdos commented on issue #1684: use unittest.mock instead of mock
Posted by GitBox <gi...@apache.org>.
pgajdos commented on issue #1684:
URL: https://github.com/apache/libcloud/issues/1684#issuecomment-1120715472
Yes, forgot to add:
https://fedoraproject.org/wiki/Changes/DeprecatePythonMock
https://trello.com/b/WsskhdXA/opensuse-python
You seem to not support Python 2 anymore and as far as I tested:
https://build.opensuse.org/package/show/home:pgajdos:python/python-apache-libcloud
the testsuite run is successful at least with python 3.6 and later (see [python-apache-libcloud-no-mock.patch](https://build.opensuse.org/package/view_file/home:pgajdos:python/python-apache-libcloud/python-apache-libcloud-no-mock.patch)).
The root of this is sake of simplicity, why not use built-in unittest.mock instead of another library. That is of course your choice and feel free to close this in case you feel it is better to stay with python-mock.
Thank you for consideration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org