You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2023/12/17 08:00:26 UTC
[PR] [CELEBORN-1181] Filter out null endpoint workers in destroySlotsWithRetry [incubator-celeborn]
waitinfuture opened a new pull request, #2166:
URL: https://github.com/apache/incubator-celeborn/pull/2166
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
To avoid NPE in `val future = workerInfo.endpoint.ask[DestroyWorkerSlotsResponse](destroy)`
### Why are the changes needed?
ditto
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manual test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1181] Filter out null endpoint workers in destroySlotsWithRetry [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #2166:
URL: https://github.com/apache/incubator-celeborn/pull/2166#issuecomment-1859155090
Thanks, merging to main(v0.4.0)/branch-0.3(v0.3.2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1181] Filter out null endpoint workers in destroySlotsWithRetry [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2166:
URL: https://github.com/apache/incubator-celeborn/pull/2166#issuecomment-1859069345
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2166?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`e361788`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/e361788e482d5fe18715dd57181903b7cdfc97ba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 46.09% compared to head [(`54b12d6`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2166?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 45.96%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2166 +/- ##
==========================================
- Coverage 46.09% 45.96% -0.13%
==========================================
Files 180 180
Lines 11519 11519
Branches 1028 1028
==========================================
- Hits 5309 5293 -16
- Misses 5861 5874 +13
- Partials 349 352 +3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2166?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1181] Filter out null endpoint workers in destroySlotsWithRetry [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #2166: [CELEBORN-1181] Filter out null endpoint workers in destroySlotsWithRetry
URL: https://github.com/apache/incubator-celeborn/pull/2166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org