You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2005/09/27 18:09:52 UTC

Re: svn commit: r16304 - trunk/subversion/bindings/swig/python/tests/trac/versioncontrol/tests

djames@tigris.org wrote:

>+        # Remove the trac-svnrepos directory, so that we can
>+        # ensure a fresh start.
>+        try:
>+          self.tearDown()
>+        except:
>+          pass
>  
>
Why the last two lines? If the test repository can't be removed, it's a 
safe bet that the tests won't work anyway.

-- Brane


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r16304 - trunk/subversion/bindings/swig/python/tests/trac/versioncontrol/tests

Posted by David James <ja...@gmail.com>.
On 9/27/05, Daniel L. Rall <dl...@finemaltcoding.com> wrote:
> On Tue, 27 Sep 2005, David James wrote:
> ...
> > (Perhaps it would be better to fix self.tearDown to check whether the
> > repository actually exists, before trying to delete it.)
>
> Yes.
Fixed in r16319.

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: svn commit: r16304 - trunk/subversion/bindings/swig/python/tests/trac/versioncontrol/tests

Posted by "Daniel L. Rall" <dl...@finemaltcoding.com>.
On Tue, 27 Sep 2005, David James wrote:
...
> (Perhaps it would be better to fix self.tearDown to check whether the
> repository actually exists, before trying to delete it.)

Yes.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r16304 - trunk/subversion/bindings/swig/python/tests/trac/versioncontrol/tests

Posted by David James <ja...@gmail.com>.
On 9/27/05, Branko Čibej <br...@xbc.nu> wrote:
> djames@tigris.org wrote:
>
> >+        # Remove the trac-svnrepos directory, so that we can
> >+        # ensure a fresh start.
> >+        try:
> >+          self.tearDown()
> >+        except:
> >+          pass
> >
> >
> Why the last two lines? If the test repository can't be removed, it's a
> safe bet that the tests won't work anyway.
If the test repository doesn't exist, then self.tearDown() throws an
exception. We catch this exception, so that the test scripts will work
if the trac-svnrepos directory has not been created yet.

(Perhaps it would be better to fix self.tearDown to check whether the
repository actually exists, before trying to delete it.)

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james