You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/07/09 16:49:25 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #6896: Revert "chore(deps): update bigdecimal requirement from 0.3.0 to 0.4.0 (#6848)"
alamb opened a new pull request, #6896:
URL: https://github.com/apache/arrow-datafusion/pull/6896
# Which issue does this PR close?
N/A
# Rationale for this change
After the `bigdecimal` upgrade to `0.4.0` in https://github.com/apache/arrow-datafusion/pull/6848, when I run `cargo test --test sqllogictests` it *always* recompiles even when there are no changes.
I tracked it down and it is due to https://github.com/akubera/bigdecimal-rs/issues/105
I would like to avoid recompiling while writing tests until that is fixed, so let's downgrade
# What changes are included in this PR?
This reverts commit d0def42c828246fed0ac7aa2ccb8877eac248a3d.
# Are these changes tested?
existing tests
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6896: Revert "chore(deps): update bigdecimal requirement from 0.3.0 to 0.4.0 (#6848)"
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6896:
URL: https://github.com/apache/arrow-datafusion/pull/6896#issuecomment-1632407550
I am merging this in because it is killing my productivity trying to use sqllogictest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6896: Revert "chore(deps): update bigdecimal requirement from 0.3.0 to 0.4.0 (#6848)"
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6896:
URL: https://github.com/apache/arrow-datafusion/pull/6896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org