[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1540: MINIFICPP-2082 Move RocksDB stats to RepositoryMetrics

["fgerlits (via GitHub)" <gi...@apache.org>]

fgerlits commented on code in PR #1540:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1540#discussion_r1219886077


##########
extensions/rocksdb-repos/RocksDbRepository.cpp:
##########
@@ -20,22 +20,30 @@ using namespace std::literals::chrono_literals;
 
 namespace org::apache::nifi::minifi::core::repository {
 
-void RocksDbRepository::printStats() {
+std::optional<RepositoryMetricsSource::RocksDbStats> RocksDbRepository::getRocksDbStats() const {

Review Comment:
   This function is identical to `DatabaseContentRepository::getRocksDbStats()`.  Could we move the common code somewhere and call it from these two places, to avoid duplication?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org