Re: svn commit: rev 1141 - trunk/subversion/libsvn_ra_dav

[Karl Fogel <kf...@newton.ch.collab.net>]

gstein@tigris.org writes:
> Log:
> With all the fancy revision stuff going on, we need to ensure that
> this function actually *fails*. The previous stub should have done an
> abort or something. We can return an error for this.

Heh!  Good call, Greg.

Is there anything tricky one should know about filling in
svn_ra_dav__get_dated_revision() or about the counterpart changes in
mod_dav_svn?  I'm thinking of doing it soon...

-K

> * fetch.c (svn_ra_dav__get_dated_revision): stub this properly.
> 
> Modified: trunk/subversion/libsvn_ra_dav/fetch.c
> ==============================================================================
> --- OLD/trunk/subversion/libsvn_ra_dav/fetch.c	Fri Feb  1 18:35:02 2002
> +++ NEW/trunk/subversion/libsvn_ra_dav/fetch.c	Fri Feb  1 18:35:02 2002
> @@ -1056,15 +1056,19 @@
>                                               svn_revnum_t *revision,
>                                               apr_time_t timestamp)
>  {
> -  *revision = 0;
> +  svn_ra_session_t *ras = session_baton;
>  
> -  /* On the other side of the network, mod_dav_svn can simply call
> -     svn_repos_dated_revision().  */
> -
> -  return SVN_NO_ERROR;
> -}
> +  /* ### need to implement this function...
> +     ###
> +     ### marshal the query over and call svn_repos_dated_revision()
> +  */
>  
> +  *revision = SVN_INVALID_REVNUM;
>  
> +  return svn_error_create(SVN_ERR_UNSUPPORTED_FEATURE, 0, NULL, ras->pool,
> +                          "ra_dav does not currently support date-based "
> +                          "operations.");
> +}
>  
>  
>  /* -------------------------------------------------------------------------
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org