You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zhijiang (JIRA)" <ji...@apache.org> on 2017/04/25 08:08:04 UTC
[jira] [Commented] (FLINK-6337) Remove the buffer provider from
PartitionRequestServerHandler
[ https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982534#comment-15982534 ]
zhijiang commented on FLINK-6337:
---------------------------------
[~uce], do you think it makes sense to remove the buffer provider from server handler? I wonder there would be future plans conflicted with it.
If not, I will submit the pull request for it. Thank you!
> Remove the buffer provider from PartitionRequestServerHandler
> -------------------------------------------------------------
>
> Key: FLINK-6337
> URL: https://issues.apache.org/jira/browse/FLINK-6337
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
>
> Currently, {{PartitionRequestServerHandler}} will create a {{LocalBufferPool}} when the channel is registered. The {{LocalBufferPool}} is only used to get segment size for creating read view in {{SpillableSubpartition}}, and the buffers in the pool will not be used all the time, so it will waste the buffer resource of global pool.
> We would like to remove the {{LocalBufferPool}} from the {{PartitionRequestServerHandler}}, and the {{LocalBufferPool}} in {{ResultPartition}} can also provide the segment size for creating sub partition view.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)