You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/02 23:16:01 UTC

Review Request 65890: Added used but not included header.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65890/
-----------------------------------------------------------

Review request for mesos, Akash Gupta and Joseph Wu.


Repository: mesos


Description
-------

This file has a `Try<Nothing>` type, but did not include
`<stout/nothing.hpp>`, resulting in a compilation error when includes
were ordered in an unlucky manner.


Diffs
-----

  src/slave/paths.hpp fff85e5c9d558f0deb2dae8032582260052413d1 


Diff: https://reviews.apache.org/r/65890/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer

Re: Review Request 65890: Added used but not included header.

Posted by Akash Gupta <ak...@hotmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65890/#review198573
-----------------------------------------------------------


Ship it!




Ship It!

- Akash Gupta


On March 2, 2018, 11:16 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65890/
> -----------------------------------------------------------
> 
> (Updated March 2, 2018, 11:16 p.m.)
> 
> 
> Review request for mesos, Akash Gupta and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This file has a `Try<Nothing>` type, but did not include
> `<stout/nothing.hpp>`, resulting in a compilation error when includes
> were ordered in an unlucky manner.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.hpp fff85e5c9d558f0deb2dae8032582260052413d1 
> 
> 
> Diff: https://reviews.apache.org/r/65890/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>