You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "Deleplace (via GitHub)" <gi...@apache.org> on 2023/09/20 13:25:55 UTC
[GitHub] [kvrocks] Deleplace opened a new issue, #1770: slices.Compact
Deleplace opened a new issue, #1770:
URL: https://github.com/apache/kvrocks/issues/1770
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues.
### Version
Hello, while researching for [this Go proposal](https://github.com/golang/go/issues/62729) I noticed [4 occurrences](https://github.com/search?q=repo%3Aapache%2Fkvrocks%20slices.Compact&type=code) of this pattern:
```
slices.Compact(keys)
```
which doesn't do what it seems to do, and should look like this instead:
```
keys = slices.Compact(keys)
```
I have not tried to execute it.
### Minimal reproduce step
Look at https://github.com/search?q=repo%3Aapache%2Fkvrocks%20slices.Compact&type=code
### What did you expect to see?
keys = slices.Compact(keys)
### What did you see instead?
slices.Compact(keys)
### Anything Else?
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] git-hulk commented on issue #1770: slices.Compact
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1770:
URL: https://github.com/apache/kvrocks/issues/1770#issuecomment-1727747903
@Deleplace Thanks for your feedback, it's exactly a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] tisonkun commented on issue #1770: slices.Compact
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #1770:
URL: https://github.com/apache/kvrocks/issues/1770#issuecomment-1727892860
@Deleplace Thanks for your reporting! It should be now fixed by #1771.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] tisonkun closed issue #1770: slices.Compact
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed issue #1770: slices.Compact
URL: https://github.com/apache/kvrocks/issues/1770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org