You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2019/06/24 08:26:01 UTC

[jira] [Commented] (HBASE-21917) Make the HFileBlock#validateChecksum can accept ByteBuff as an input.

    [ https://issues.apache.org/jira/browse/HBASE-21917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870921#comment-16870921 ] 

Hudson commented on HBASE-21917:
--------------------------------

Results for branch master
	[build #1168 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1168/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1168//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1168//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1168//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Make the HFileBlock#validateChecksum can accept ByteBuff as an input.
> ---------------------------------------------------------------------
>
>                 Key: HBASE-21917
>                 URL: https://issues.apache.org/jira/browse/HBASE-21917
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>            Priority: Major
>         Attachments: HBASE-21917.HBASE-21879.v5.patch, HBASE-21917.HBASE-21879.v6.patch, HBASE-21917.addendum.HBASE-21879.v7.patch, HBASE-21917.v1.patch, HBASE-21917.v2.patch, HBASE-21917.v3.patch, HBASE-21917.v4.patch
>
>
> I've tried to make a patch for HBASE-21879, most of work seems to be fine, but the trouble is: 
> HFileBlock#validateChecksum can only accept ByteBuffer as its input, while after the HBASE-21916, we will use an ourself-defined ByteBuff (which can be SingleByteBuff or MultiByteBuff). 
> Now, need to create our own ByteBuff checksum validation method, should not be so hard but an separate issue will be more clearer.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)