[GitHub] [bookkeeper] 29x10 commented on a change in pull request #2128: Issue #2127: Allow user override default SASL service name bookkeeper

[GitBox <gi...@apache.org>]

29x10 commented on a change in pull request #2128: Issue #2127: Allow user override default SASL service name bookkeeper
URL: https://github.com/apache/bookkeeper/pull/2128#discussion_r305564393
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/sasl/SaslClientState.java
 ##########
 @@ -50,7 +50,9 @@
     private String password;
 
     public SaslClientState(String serverHostname, Subject subject) throws SaslException {
-        String serverPrincipal = SaslConstants.SASL_BOOKKEEPER_PROTOCOL + "/" + serverHostname;
+        String saslServiceName = System.getProperty("bookkeeper.sasl.servicename",
 
 Review comment:
   Sorry I couldn't find any existing tests that use SaslClientState.
   
   And this only affect client side, when client authenticate with server, you need to provide server's service name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services