[GitHub] [zookeeper] li4wang commented on a change in pull request #1773: ZOOKEEPER-4396: Read Key/trust store password from file

[GitBox <gi...@apache.org>]

li4wang commented on a change in pull request #1773:
URL: https://github.com/apache/zookeeper/pull/1773#discussion_r728387457



##########
File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
##########
@@ -1636,6 +1636,12 @@ and [SASL authentication for ZooKeeper](https://cwiki.apache.org/confluence/disp
     Specifies the file path to a Java keystore containing the local
     credentials to be used for client and quorum TLS connections, and the
     password to unlock the file.
+    
+* *ssl.keyStore.passwordPath* and *ssl.quorum.keyStore.passwordPath* :
+    (Java system properties: **zookeeper.ssl.keyStore.passwordPath** and **zookeeper.ssl.quorum.keyStore.passwordPath**)

Review comment:
       @christ Thanks for the comment. Yep, the alternative implementation is more extensible and can reduce the number of properties if more options need to be supported.  Is there any reason that password handling didn't start that way?  
   
   @anmolnar @makubi @eolivelli @ztzg any thoughts on this? 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org