You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/03/03 06:16:05 UTC
[jira] [Commented] (THRIFT-3020) Cannot compile thrift as C++03
[ https://issues.apache.org/jira/browse/THRIFT-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344547#comment-14344547 ]
ASF GitHub Bot commented on THRIFT-3020:
----------------------------------------
GitHub user zsims opened a pull request:
https://github.com/apache/thrift/pull/384
[THRIFT-3020] Removes C++11 style field initialization
See https://issues.apache.org/jira/browse/THRIFT-3020
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsims/thrift field-init
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/384.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #384
----
commit dacbee68444aeded794ff445559367b538113c91
Author: Zachary Sims <z....@qsr.com.au>
Date: 2015-03-03T05:12:31Z
Removes C++11-style field initialisation in TBufferTransports.h
----
> Cannot compile thrift as C++03
> ------------------------------
>
> Key: THRIFT-3020
> URL: https://issues.apache.org/jira/browse/THRIFT-3020
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.2
> Environment: Visual Studio 2010
> Reporter: Zachary Sims
>
> Thrift no longer compiles under C++03, given the recent fix for THRIFT-2937. This is due to the way a field is initialized with a default value.
> The compilation error:
> {code}
> Error 1 error C2864: 'apache::thrift::transport::TFramedTransport::maxFrameSize_' : only static const integral data members can be initialized within a class D:\dev\thrift\lib\cpp\src\thrift\transport\TBufferTransports.h 404 1 thrift_static
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)