You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/23 21:39:17 UTC
[GitHub] [spark] jzhuge opened a new pull request #35636: [SPARK-31357][SQL][WIP] Catalog API for view metadata
jzhuge opened a new pull request #35636:
URL: https://github.com/apache/spark/pull/35636
### What changes were proposed in this pull request?
This PR adds support to load, create, alter, and drop views in DataSource V2 catalogs.
This is an umbrella PR that combines the following commits that probably should be merged one by one.
- View catalog interface
- View substitution rule
- Create view DDL
- View SQL DDLs
### Why are the changes needed?
Support views stored in DataSourceV2 catalogs. Details in [SPIP](https://docs.google.com/document/d/1XOxFtloiMuW24iqJ-zJnDzHl2KMxipTjJoxleJFz66A/edit?usp=sharing).
### Does this PR introduce any user-facing change?
- Support views from DataSource V2 catalogs in SQL
- Support views from DataSource V2 catalogs in DataFrame API
### How was this patch tested?
New unit tests
Regression
- DDLParserSuite
- PlanResolutionSuite
- DataSourceV2SQLSuite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jzhuge commented on pull request #35636: [SPARK-31357][SQL][WIP] Catalog API for view metadata
Posted by GitBox <gi...@apache.org>.
jzhuge commented on pull request #35636:
URL: https://github.com/apache/spark/pull/35636#issuecomment-1084866539
Retest please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen commented on pull request #35636: [SPARK-31357][SQL][WIP] Catalog API for view metadata
Posted by GitBox <gi...@apache.org>.
xkrogen commented on pull request #35636:
URL: https://github.com/apache/spark/pull/35636#issuecomment-1055950260
@jzhuge The PR as-is seems to only contain the view catalog interface, not the other 3 facets that you mentioned. Is this intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jzhuge commented on pull request #35636: [SPARK-31357][SQL][WIP] Catalog API for view metadata
Posted by GitBox <gi...@apache.org>.
jzhuge commented on pull request #35636:
URL: https://github.com/apache/spark/pull/35636#issuecomment-1055958602
Sorry, not added yet.
On Tue, Mar 1, 2022 at 3:07 PM Erik Krogen ***@***.***> wrote:
> @jzhuge <https://github.com/jzhuge> The PR as-is seems to only contain
> the view catalog interface, not the other 3 facets that you mentioned. Is
> this intentional?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/35636#issuecomment-1055950260>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAOL5JBTAQ7T2PPHR73HSFLU52PJLANCNFSM5PFSWFAQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
John Zhuge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] melin commented on pull request #35636: [SPARK-31357][SQL][WIP] Catalog API for view metadata
Posted by GitBox <gi...@apache.org>.
melin commented on pull request #35636:
URL: https://github.com/apache/spark/pull/35636#issuecomment-1064910166
https://github.com/apache/spark/pull/28147 PR available? Why submit a new PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org