You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/20 01:57:38 UTC
[GitHub] [lucene-solr] dsmiley opened a new pull request #2408: SOLR-13034: RTG sometimes didn't materialize LazyField
dsmiley opened a new pull request #2408:
URL: https://github.com/apache/lucene-solr/pull/2408
Partial (AKA Atomic) updates could encounter "LazyField" instances in the document
cache and not know hot to deal with them when writing the updated doc to the update log.
https://issues.apache.org/jira/browse/SOLR-13034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley merged pull request #2408: SOLR-13034: RTG sometimes didn't materialize LazyField
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #2408:
URL: https://github.com/apache/lucene-solr/pull/2408
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #2408: SOLR-13034: RTG sometimes didn't materialize LazyField
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #2408:
URL: https://github.com/apache/lucene-solr/pull/2408#issuecomment-783429388
Kind of a long-shot request for a code review @ErickErickson but it's an easy one and you had once looked at the relevant code.
Overall, I feel this change is super simple & safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2408: SOLR-13034: RTG sometimes didn't materialize LazyField
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #2408:
URL: https://github.com/apache/lucene-solr/pull/2408#discussion_r581407353
##########
File path: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
##########
@@ -813,8 +813,8 @@ private static SolrInputDocument toSolrInputDocument(SolrDocument doc, IndexSche
if ((!sf.hasDocValues() && !sf.stored()) || schema.isCopyFieldTarget(sf)) continue;
}
for (Object val: doc.getFieldValues(fname)) {
- if (val instanceof Field) {
- Field f = (Field) val;
+ if (val instanceof IndexableField) {
+ IndexableField f = materialize((IndexableField) val);
Review comment:
Spot on!
I'm now looking to see if I can do some simplifications here; tay tuned...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #2408: SOLR-13034: RTG sometimes didn't materialize LazyField
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #2408:
URL: https://github.com/apache/lucene-solr/pull/2408#discussion_r581277027
##########
File path: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
##########
@@ -813,8 +813,8 @@ private static SolrInputDocument toSolrInputDocument(SolrDocument doc, IndexSche
if ((!sf.hasDocValues() && !sf.stored()) || schema.isCopyFieldTarget(sf)) continue;
}
for (Object val: doc.getFieldValues(fname)) {
- if (val instanceof Field) {
- Field f = (Field) val;
+ if (val instanceof IndexableField) {
+ IndexableField f = materialize((IndexableField) val);
Review comment:
you don't need this call to materialize, the next calls to `toObject` or `stringValue` will do that for you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org