You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Fang Wang <fa...@citrix.com> on 2013/06/14 00:55:20 UTC
Re: Review Request: Fix a logging issue in my previsous hypervisor template
code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11052/
-----------------------------------------------------------
(Updated June 13, 2013, 10:55 p.m.)
Review request for cloudstack, edison su and Kelven Yang.
Changes
-------
Edison, can you review it for me? thanks.
Description
-------
As Alex pointed out, I need not to log the stacktrace in the hypervisorTemplateAdapter method to obtain the OVA packing. Fix it and remove the logging.
Diffs
-----
server/src/com/cloud/template/HypervisorTemplateAdapter.java 322f32e
Diff: https://reviews.apache.org/r/11052/diff/
Testing
-------
Thanks,
Fang Wang
Re: Review Request: Fix a logging issue in my previsous hypervisor template
code.
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11052/#review21898
-----------------------------------------------------------
server/src/com/cloud/template/HypervisorTemplateAdapter.java
<https://reviews.apache.org/r/11052/#comment45190>
Why put this log for the cmd when its going to be logged by default ?
server/src/com/cloud/template/HypervisorTemplateAdapter.java
<https://reviews.apache.org/r/11052/#comment45191>
I would expect atleast logging or throwing the same exception...else we are just hiding the exception.
Same for the commented statement below.
- Nitin Mehta
On June 13, 2013, 10:55 p.m., Fang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11052/
> -----------------------------------------------------------
>
> (Updated June 13, 2013, 10:55 p.m.)
>
>
> Review request for cloudstack, edison su and Kelven Yang.
>
>
> Description
> -------
>
> As Alex pointed out, I need not to log the stacktrace in the hypervisorTemplateAdapter method to obtain the OVA packing. Fix it and remove the logging.
>
>
> Diffs
> -----
>
> server/src/com/cloud/template/HypervisorTemplateAdapter.java 322f32e
>
> Diff: https://reviews.apache.org/r/11052/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Fang Wang
>
>