You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:20:36 UTC

[GitHub] [kylin] kyotoYaho commented on a change in pull request #1325: KYLIN-4653 Make the capacity for the LinkedBlockingQueue of BlockingR…

kyotoYaho commented on a change in pull request #1325:
URL: https://github.com/apache/kylin/pull/1325#discussion_r461342816



##########
File path: core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/BlockingReservoir.java
##########
@@ -60,6 +60,10 @@ public BlockingReservoir(int minReportSize, int maxReportSize) {
     }
 
     public BlockingReservoir(int minReportSize, int maxReportSize, int maxReportTime) {
+        this(minReportSize, maxReportSize, maxReportSize, MAX_QUEUE_SIZE);

Review comment:
       it should be 
   {code}
   this(minReportSize, maxReportSize, maxReportTime, MAX_QUEUE_SIZE);
   {code}




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org