You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/12 14:13:44 UTC
[GitHub] [flink] derekm opened a new pull request #16795: [FLINK-23729][sql-client] Make sql-client.sh work on Windows
derekm opened a new pull request #16795:
URL: https://github.com/apache/flink/pull/16795
## What is the purpose of the change
Allow sql-client.sh to work on Windows machines with "msys" bash.
https://issues.apache.org/jira/browse/FLINK-23729
## Brief change log
- Make manglePath() and manglePathList() in config.sh aware of "msys" $OSTYPE
- Make log4j.configurationFile system property an absolute `file:` scheme path instead of a relative path
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Changes to config.sh and sql-client.sh were manually tested on both Windows and Linux to find the appropriate minimal changes that would lead to identical behavior on both platforms.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #16795: [FLINK-23729][sql-client] Make sql-client.sh work on Windows
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #16795:
URL: https://github.com/apache/flink/pull/16795#issuecomment-897808440
Closing because we are not supporting Windows, as mentioned in the JIRA. I would recommend working with something like WSL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] derekm commented on pull request #16795: [FLINK-23729][sql-client] Make sql-client.sh work on Windows
Posted by GitBox <gi...@apache.org>.
derekm commented on pull request #16795:
URL: https://github.com/apache/flink/pull/16795#issuecomment-898593584
Just reporting back that the Cygwin stuff in master doesn't work as-is, despite documentation to the contrary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol closed pull request #16795: [FLINK-23729][sql-client] Make sql-client.sh work on Windows
Posted by GitBox <gi...@apache.org>.
zentol closed pull request #16795:
URL: https://github.com/apache/flink/pull/16795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16795: [FLINK-23729][sql-client] Make sql-client.sh work on Windows
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16795:
URL: https://github.com/apache/flink/pull/16795#issuecomment-897697676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ebbb62b14ae7aa982454bd761d7bb32f330b36c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22003",
"triggerID" : "2ebbb62b14ae7aa982454bd761d7bb32f330b36c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ebbb62b14ae7aa982454bd761d7bb32f330b36c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22003)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16795: [FLINK-23729][sql-client] Make sql-client.sh work on Windows
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16795:
URL: https://github.com/apache/flink/pull/16795#issuecomment-897678023
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2ebbb62b14ae7aa982454bd761d7bb32f330b36c (Thu Aug 12 14:17:10 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-23729).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] derekm commented on pull request #16795: [FLINK-23729][sql-client] Make sql-client.sh work on Windows
Posted by GitBox <gi...@apache.org>.
derekm commented on pull request #16795:
URL: https://github.com/apache/flink/pull/16795#issuecomment-897917732
I see, @zentol -- thanks!
I'm working on a guide for Pravega + Debezium + Flink SQL, and I'm trying to make it suitable for Windows users. I'm trying to avoid introducing Docker or WSL, as they require looking up guest and host IPs on random container subnets.
Comments on the issue read like Cygwin is supported for now. Perhaps my guide can rely on Cygwin instead of Git Bash for the time being.
Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16795: [FLINK-23729][sql-client] Make sql-client.sh work on Windows
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16795:
URL: https://github.com/apache/flink/pull/16795#issuecomment-897697676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ebbb62b14ae7aa982454bd761d7bb32f330b36c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2ebbb62b14ae7aa982454bd761d7bb32f330b36c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ebbb62b14ae7aa982454bd761d7bb32f330b36c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] derekm commented on pull request #16795: [FLINK-23729][sql-client] Make sql-client.sh work on Windows
Posted by GitBox <gi...@apache.org>.
derekm commented on pull request #16795:
URL: https://github.com/apache/flink/pull/16795#issuecomment-897918312
PS: I was also working to incorporate findings from here: https://gist.github.com/codspire/0020b60d5e1cc1f40d312be11829687d ... But I'll leave it alone for the time being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org