You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "huangxiaopingRD (via GitHub)" <gi...@apache.org> on 2024/05/11 08:54:16 UTC
[PR] [CELEBORN-1419] Avoid adding shuffle id repeatedly [celeborn]
huangxiaopingRD opened a new pull request, #2503:
URL: https://github.com/apache/celeborn/pull/2503
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Avoid adding shuffle id repeatedly
### Why are the changes needed?
`registerShuffle` has added the shuffle id to `sortShuffleIds`, and there is no need to add it repeatedly when calling `getWriter`
### Does this PR introduce _any_ user-facing change?
None
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1419] Avoid adding shuffle id repeatedly [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #2503: [CELEBORN-1419] Avoid adding shuffle id repeatedly
URL: https://github.com/apache/celeborn/pull/2503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1419] Avoid adding shuffle id repeatedly [celeborn]
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on PR #2503:
URL: https://github.com/apache/celeborn/pull/2503#issuecomment-2106515993
> Thanks. I found that it's not removed when `unregisterShuffle`. Would you mind fixing this in passing?
>
> ```diff
> - if (sortShuffleIds.contains(appShuffleId)) {
> + if (sortShuffleIds.remove(appShuffleId)) {
> ```
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org