You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Weijun-H (via GitHub)" <gi...@apache.org> on 2023/03/15 21:10:56 UTC

[GitHub] [arrow-rs] Weijun-H opened a new pull request, #3872: chore: remove LevelDecode

Weijun-H opened a new pull request, #3872:
URL: https://github.com/apache/arrow-rs/pull/3872

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #2379
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #3872: chore: remove LevelDecoder

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3872:
URL: https://github.com/apache/arrow-rs/pull/3872#issuecomment-1553252899

   The page header contains the encoding, either `Encoding::RLE` or `Encoding::BIT_PACKED`, based on this you can select either to use `RleDecoder` or `BitReader`, which should do what you require. This is why LevelDecoder is no longer used, it is redundant.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #3872: chore: remove LevelDecoder

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3872:
URL: https://github.com/apache/arrow-rs/pull/3872#issuecomment-1553219409

   > LevelDecoder to read repetition and definition levels
   
   What do you think of:
   
   * Use RleDecoder's directly
   * Maintain LevelDecoder within your own project
   
   I would rather avoid maintaining an experimental API that isn't used by any of the first-class APIs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] zeevm commented on pull request #3872: chore: remove LevelDecoder

Posted by "zeevm (via GitHub)" <gi...@apache.org>.
zeevm commented on PR #3872:
URL: https://github.com/apache/arrow-rs/pull/3872#issuecomment-1553234993

   I am using RleDecoder of course to decode the RLE into dictionary IDs.
   
   I am using LevelDecoder for 2 things:
   1. Get the definition levels (so I know which positions are null or defined)
   2. Find the position within the ByteBufferPtr where the RLE encoded values start to feed into the RLE decoder in V1 pages since those pages don't have the size of the definition/repetition levels in the page header


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #3872: chore: remove LevelDecoder

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3872:
URL: https://github.com/apache/arrow-rs/pull/3872


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] zeevm commented on pull request #3872: chore: remove LevelDecoder

Posted by "zeevm (via GitHub)" <gi...@apache.org>.
zeevm commented on PR #3872:
URL: https://github.com/apache/arrow-rs/pull/3872#issuecomment-1553212348

   Hi,
   In my use of parquet-rs, I have a flow that reads and computes over the raw dictionary IDs in data pages, to get to those I'm using LevelDecoder to read repetition and definition levels, this change broke my code.
   
   I'd like to put LevelDecoder back in WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org