You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/24 12:25:23 UTC

[GitHub] [dubbo-go-pixiu] PhilYue opened a new pull request #255: Feat: Pixiu connect with SpringCloud Server by nacos 

PhilYue opened a new pull request #255:
URL: https://github.com/apache/dubbo-go-pixiu/pull/255


   <!--  Thanks for sending a pull request! 
   -->
   
   **What this PR does**: 
   
   Pixiu connect with SpringCloud Server
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes # 
   nope
   
   **Special notes for your reviewer**:
   nope
   
   **Does this PR introduce a user-facing change?**:
   nope
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #255: Feat: Pixiu connect with SpringCloud Server by nacos

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #255:
URL: https://github.com/apache/dubbo-go-pixiu/pull/255#issuecomment-931404441


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#255](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9867f2) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/6a282f047c0cedbd46d2d58f779efb68fabc4343?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6a282f0) will **decrease** coverage by `0.19%`.
   > The diff coverage is `47.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #255      +/-   ##
   ===========================================
   - Coverage    39.75%   39.56%   -0.20%     
   ===========================================
     Files           50       50              
     Lines         2568     2626      +58     
   ===========================================
   + Hits          1021     1039      +18     
   - Misses        1436     1475      +39     
   - Partials       111      112       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/extension/adapter/adapter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vYWRhcHRlci9hZGFwdGVyLmdv) | `58.33% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `54.16% <0.00%> (-2.36%)` | :arrow_down: |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.18% <0.00%> (-0.14%)` | :arrow_down: |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `60.00% <0.00%> (-3.64%)` | :arrow_down: |
   | [pkg/server/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9waXhpdV9zdGFydC5nbw==) | `0.00% <ø> (ø)` | |
   | [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `45.45% <41.79%> (-22.84%)` | :arrow_down: |
   | [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `88.00% <100.00%> (-2.00%)` | :arrow_down: |
   | [pkg/server/adapter\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9hZGFwdGVyX21hbmFnZXIuZ28=) | `72.41% <100.00%> (+4.55%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a282f0...f9867f2](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #255: Feat: Pixiu connect with SpringCloud Server by nacos

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #255:
URL: https://github.com/apache/dubbo-go-pixiu/pull/255#issuecomment-931404441


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#255](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27f2a7f) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/7e8add1fd86b77bd311bad6b901eb8b8d4c305ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e8add1) will **decrease** coverage by `0.19%`.
   > The diff coverage is `47.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #255      +/-   ##
   ===========================================
   - Coverage    39.75%   39.56%   -0.20%     
   ===========================================
     Files           50       50              
     Lines         2568     2626      +58     
   ===========================================
   + Hits          1021     1039      +18     
   - Misses        1436     1475      +39     
   - Partials       111      112       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/extension/adapter/adapter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vYWRhcHRlci9hZGFwdGVyLmdv) | `58.33% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `54.16% <0.00%> (-2.36%)` | :arrow_down: |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.18% <0.00%> (-0.14%)` | :arrow_down: |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `60.00% <0.00%> (-3.64%)` | :arrow_down: |
   | [pkg/server/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9waXhpdV9zdGFydC5nbw==) | `0.00% <ø> (ø)` | |
   | [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `45.45% <41.79%> (-22.84%)` | :arrow_down: |
   | [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `88.00% <100.00%> (-2.00%)` | :arrow_down: |
   | [pkg/server/adapter\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9hZGFwdGVyX21hbmFnZXIuZ28=) | `72.41% <100.00%> (+4.55%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e8add1...27f2a7f](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] PhilYue commented on a change in pull request #255: Feat: Pixiu connect with SpringCloud Server by nacos

Posted by GitBox <gi...@apache.org>.
PhilYue commented on a change in pull request #255:
URL: https://github.com/apache/dubbo-go-pixiu/pull/255#discussion_r720120866



##########
File path: pkg/adapter/springcloud/servicediscovery/servicediscovery.go
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package servicediscovery
+
+import (
+	"fmt"
+)
+
+import (
+	"github.com/apache/dubbo-go-pixiu/pkg/model"
+)
+
+type (
+	// ServiceInstance the service instance info fetched from registry such as nacos consul
+	ServiceInstance struct {
+		ID          string
+		ServiceName string
+		// host:port
+		Host        string
+		Port        int
+		Healthy     bool
+		CLusterName string
+		Enable      bool
+		// extra info such as label or other meta data
+		Metadata map[string]string
+	}
+
+	ServiceEventListener interface {
+		OnAddServiceInstance(r *ServiceInstance)
+		OnDeleteServiceInstance(r *ServiceInstance)
+		OnUpdateServiceInstance(r *ServiceInstance)
+		GetServiceNames() []string
+	}
+
+	ServiceDiscovery interface {
+		// 直接向远程注册中心查询所有服务实例

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #255: Feat: Pixiu connect with SpringCloud Server by nacos

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #255:
URL: https://github.com/apache/dubbo-go-pixiu/pull/255#discussion_r719958026



##########
File path: pkg/registry/zookeeper.go
##########
@@ -18,6 +18,7 @@
 package registry
 
 import (
+	"github.com/apache/dubbo-go-pixiu/pkg/model"

Review comment:
       move it to the 3rd import block.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #255: Feat: Pixiu connect with SpringCloud Server by nacos

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #255:
URL: https://github.com/apache/dubbo-go-pixiu/pull/255#discussion_r719959427



##########
File path: pkg/adapter/springcloud/cloud.go
##########
@@ -64,58 +80,259 @@ func (p *CloudPlugin) Kind() string {
 }
 
 // CreateAdapter create adapter
-func (p *CloudPlugin) CreateAdapter(config interface{}, bs *model.Bootstrap) (adapter.Adapter, error) {
-	return &CloudAdapter{cfg: &Config{}}, nil
+func (p *CloudPlugin) CreateAdapter(ad *model.Adapter) (adapter.Adapter, error) {
+	return &CloudAdapter{cfg: &Config{}, stopChan: make(chan struct{}), currentService: make(map[string]*Service)}, nil
 }
 
 // Start start the adapter
-func (a *CloudAdapter) Start() {
+func (a *CloudAdapter) Start(adapter *model.Adapter) {
 	// do not block the main goroutine
-	go func() {
-		// fetch service instance from consul
-
-		// transform into endpoint and cluster
-		endpoint := &model.Endpoint{}
-		endpoint.ID = "user-mock-service"
-		endpoint.Address = model.SocketAddress{
-			Address: "127.0.0.1",
-			Port:    8080,
-		}
-		cluster := &model.Cluster{}
-		cluster.Name = "userservice"
-		cluster.Lb = model.Rand
-		cluster.Endpoints = []*model.Endpoint{
-			endpoint,
-		}
-		// add cluster into manager
-		cm := server.GetClusterManager()
-		cm.AddCluster(cluster)
-
-		// transform into route
-		routeMatch := model.RouterMatch{
-			Prefix: "/user",
-		}
-		routeAction := model.RouteAction{
-			Cluster: "userservice",
-		}
-		route := &model.Router{Match: routeMatch, Route: routeAction}
+	// init get all service instance
+	err := a.firstFetch()
+	if err != nil {
+		logger.Errorf("init fetch service fail", err.Error())
+		return
+	}
 
-		server.GetRouterManager().AddRouter(route)
+	// background sync service instance from remote
+	err = a.backgroundSyncPeriod()
+	if err != nil {
+		logger.Errorf("init periodicity fetch service task fail", err.Error())
+		return
+	}
 
-	}()
+	// watch then fetch is more safety for consistent but there is background fresh mechanism
+	err = a.watch()
+	if err != nil {
+		logger.Errorf("init watch the register fail", err.Error())
+		return
+	}
 }
 
 // Stop stop the adapter
 func (a *CloudAdapter) Stop() {
-
+	err := a.stop()
+	if err != nil {
+		logger.Errorf("stop the adapter fail", err.Error())
+		return
+	}
 }
 
 // Apply init
 func (a *CloudAdapter) Apply() error {
+	//registryUsed := ad.Config["registry"].(map[string]interface{})
+	switch a.cfg.Registry.Protocol {
+	case "nacos":
+		sd, err := nacos.NewNacosServiceDiscovery(a.cfg.Services, a.cfg.Registry, a)
+		if err != nil {
+			logger.Errorf("Apply NewNacosServiceDiscovery", err.Error())
+			return err
+		}
+		a.sd = sd
+	case "consul":
+	case "zookeeper":
+	default:
+		return errors.New("adapter init error registry not recognise")
+	}
 	return nil
 }
 
+func (a *CloudAdapter) OnAddServiceInstance(instance *servicediscovery.ServiceInstance) {
+	cm := server.GetClusterManager()
+	endpoint := instance.ToEndpoint()
+
+	a.mutex.Lock()
+	defer a.mutex.Unlock()
+
+	// endpoint name should equal with cluster name
+	cm.SetEndpoint(endpoint.Name, endpoint)
+	if a.checkHasExistService(endpoint.Name) {
+		return
+	}
+	// new service, so add route and into CurrentService map
+	a.addNewService(instance)
+	// route ID is cluster name, so equal with endpoint name
+	rm := server.GetRouterManager()
+	route := instance.ToRoute()
+	rm.AddRouter(route)
+}
+
+func (a *CloudAdapter) OnDeleteServiceInstance(instance *servicediscovery.ServiceInstance) {
+	cm := server.GetClusterManager()
+	endpoint := instance.ToEndpoint()
+
+	cm.DeleteEndpoint(endpoint.Name, endpoint.ID)
+
+}
+
+func (a *CloudAdapter) OnUpdateServiceInstance(instance *servicediscovery.ServiceInstance) {
+	cm := server.GetClusterManager()
+	endpoint := instance.ToEndpoint()
+	a.mutex.Lock()
+	defer a.mutex.Unlock()
+	cm.SetEndpoint(endpoint.Name, endpoint)
+}
+
+func (a *CloudAdapter) GetServiceNames() []string {
+	a.mutex.Lock()
+	defer a.mutex.Unlock()
+
+	var res []string

Review comment:
       res := make([]string, 0, len(a.currentService))




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] PhilYue commented on a change in pull request #255: Feat: Pixiu connect with SpringCloud Server by nacos

Posted by GitBox <gi...@apache.org>.
PhilYue commented on a change in pull request #255:
URL: https://github.com/apache/dubbo-go-pixiu/pull/255#discussion_r720122034



##########
File path: pkg/adapter/springcloud/cloud.go
##########
@@ -64,58 +80,259 @@ func (p *CloudPlugin) Kind() string {
 }
 
 // CreateAdapter create adapter
-func (p *CloudPlugin) CreateAdapter(config interface{}, bs *model.Bootstrap) (adapter.Adapter, error) {
-	return &CloudAdapter{cfg: &Config{}}, nil
+func (p *CloudPlugin) CreateAdapter(ad *model.Adapter) (adapter.Adapter, error) {
+	return &CloudAdapter{cfg: &Config{}, stopChan: make(chan struct{}), currentService: make(map[string]*Service)}, nil
 }
 
 // Start start the adapter
-func (a *CloudAdapter) Start() {
+func (a *CloudAdapter) Start(adapter *model.Adapter) {
 	// do not block the main goroutine
-	go func() {
-		// fetch service instance from consul
-
-		// transform into endpoint and cluster
-		endpoint := &model.Endpoint{}
-		endpoint.ID = "user-mock-service"
-		endpoint.Address = model.SocketAddress{
-			Address: "127.0.0.1",
-			Port:    8080,
-		}
-		cluster := &model.Cluster{}
-		cluster.Name = "userservice"
-		cluster.Lb = model.Rand
-		cluster.Endpoints = []*model.Endpoint{
-			endpoint,
-		}
-		// add cluster into manager
-		cm := server.GetClusterManager()
-		cm.AddCluster(cluster)
-
-		// transform into route
-		routeMatch := model.RouterMatch{
-			Prefix: "/user",
-		}
-		routeAction := model.RouteAction{
-			Cluster: "userservice",
-		}
-		route := &model.Router{Match: routeMatch, Route: routeAction}
+	// init get all service instance
+	err := a.firstFetch()
+	if err != nil {
+		logger.Errorf("init fetch service fail", err.Error())
+		return
+	}
 
-		server.GetRouterManager().AddRouter(route)
+	// background sync service instance from remote
+	err = a.backgroundSyncPeriod()
+	if err != nil {
+		logger.Errorf("init periodicity fetch service task fail", err.Error())
+		return
+	}
 
-	}()
+	// watch then fetch is more safety for consistent but there is background fresh mechanism
+	err = a.watch()
+	if err != nil {
+		logger.Errorf("init watch the register fail", err.Error())
+		return
+	}
 }
 
 // Stop stop the adapter
 func (a *CloudAdapter) Stop() {
-
+	err := a.stop()
+	if err != nil {
+		logger.Errorf("stop the adapter fail", err.Error())
+		return
+	}
 }
 
 // Apply init
 func (a *CloudAdapter) Apply() error {
+	//registryUsed := ad.Config["registry"].(map[string]interface{})
+	switch a.cfg.Registry.Protocol {
+	case "nacos":
+		sd, err := nacos.NewNacosServiceDiscovery(a.cfg.Services, a.cfg.Registry, a)
+		if err != nil {
+			logger.Errorf("Apply NewNacosServiceDiscovery", err.Error())
+			return err
+		}
+		a.sd = sd
+	case "consul":
+	case "zookeeper":
+	default:
+		return errors.New("adapter init error registry not recognise")
+	}
 	return nil
 }
 
+func (a *CloudAdapter) OnAddServiceInstance(instance *servicediscovery.ServiceInstance) {
+	cm := server.GetClusterManager()
+	endpoint := instance.ToEndpoint()
+
+	a.mutex.Lock()
+	defer a.mutex.Unlock()
+
+	// endpoint name should equal with cluster name
+	cm.SetEndpoint(endpoint.Name, endpoint)
+	if a.checkHasExistService(endpoint.Name) {
+		return
+	}
+	// new service, so add route and into CurrentService map
+	a.addNewService(instance)
+	// route ID is cluster name, so equal with endpoint name
+	rm := server.GetRouterManager()
+	route := instance.ToRoute()
+	rm.AddRouter(route)
+}
+
+func (a *CloudAdapter) OnDeleteServiceInstance(instance *servicediscovery.ServiceInstance) {
+	cm := server.GetClusterManager()
+	endpoint := instance.ToEndpoint()
+
+	cm.DeleteEndpoint(endpoint.Name, endpoint.ID)
+
+}
+
+func (a *CloudAdapter) OnUpdateServiceInstance(instance *servicediscovery.ServiceInstance) {
+	cm := server.GetClusterManager()
+	endpoint := instance.ToEndpoint()
+	a.mutex.Lock()
+	defer a.mutex.Unlock()
+	cm.SetEndpoint(endpoint.Name, endpoint)
+}
+
+func (a *CloudAdapter) GetServiceNames() []string {
+	a.mutex.Lock()
+	defer a.mutex.Unlock()
+
+	var res []string

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] PhilYue commented on a change in pull request #255: Feat: Pixiu connect with SpringCloud Server by nacos

Posted by GitBox <gi...@apache.org>.
PhilYue commented on a change in pull request #255:
URL: https://github.com/apache/dubbo-go-pixiu/pull/255#discussion_r720120783



##########
File path: pkg/registry/zookeeper.go
##########
@@ -18,6 +18,7 @@
 package registry
 
 import (
+	"github.com/apache/dubbo-go-pixiu/pkg/model"

Review comment:
       done
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #255: Feat: Pixiu connect with SpringCloud Server by nacos

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #255:
URL: https://github.com/apache/dubbo-go-pixiu/pull/255#discussion_r719958771



##########
File path: pkg/adapter/springcloud/servicediscovery/servicediscovery.go
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package servicediscovery
+
+import (
+	"fmt"
+)
+
+import (
+	"github.com/apache/dubbo-go-pixiu/pkg/model"
+)
+
+type (
+	// ServiceInstance the service instance info fetched from registry such as nacos consul
+	ServiceInstance struct {
+		ID          string
+		ServiceName string
+		// host:port
+		Host        string
+		Port        int
+		Healthy     bool
+		CLusterName string
+		Enable      bool
+		// extra info such as label or other meta data
+		Metadata map[string]string
+	}
+
+	ServiceEventListener interface {
+		OnAddServiceInstance(r *ServiceInstance)
+		OnDeleteServiceInstance(r *ServiceInstance)
+		OnUpdateServiceInstance(r *ServiceInstance)
+		GetServiceNames() []string
+	}
+
+	ServiceDiscovery interface {
+		// 直接向远程注册中心查询所有服务实例

Review comment:
       translate it into english




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #255: Feat: Pixiu connect with SpringCloud Server by nacos

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #255:
URL: https://github.com/apache/dubbo-go-pixiu/pull/255#issuecomment-931404441


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#255](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ce7102) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/3a158665e05e72f2890726a052dfa40b1942abd8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a15866) will **increase** coverage by `0.05%`.
   > The diff coverage is `43.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #255      +/-   ##
   ===========================================
   + Coverage    39.51%   39.56%   +0.05%     
   ===========================================
     Files           50       50              
     Lines         2584     2626      +42     
   ===========================================
   + Hits          1021     1039      +18     
   - Misses        1452     1475      +23     
   - Partials       111      112       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `42.16% <0.00%> (-1.05%)` | :arrow_down: |
   | [pkg/common/extension/adapter/adapter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vYWRhcHRlci9hZGFwdGVyLmdv) | `58.33% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `54.16% <0.00%> (-2.36%)` | :arrow_down: |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.18% <0.00%> (-0.14%)` | :arrow_down: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `60.00% <0.00%> (-3.64%)` | :arrow_down: |
   | [pkg/server/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9waXhpdV9zdGFydC5nbw==) | `0.00% <ø> (ø)` | |
   | [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `45.45% <41.79%> (-22.84%)` | :arrow_down: |
   | [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `88.00% <100.00%> (-2.00%)` | :arrow_down: |
   | [pkg/server/adapter\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9hZGFwdGVyX21hbmFnZXIuZ28=) | `72.41% <100.00%> (+4.55%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3a15866...4ce7102](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #255: Feat: Pixiu connect with SpringCloud Server by nacos

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #255:
URL: https://github.com/apache/dubbo-go-pixiu/pull/255#issuecomment-931404441


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#255](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27f2a7f) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/7e8add1fd86b77bd311bad6b901eb8b8d4c305ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e8add1) will **decrease** coverage by `0.19%`.
   > The diff coverage is `47.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #255      +/-   ##
   ===========================================
   - Coverage    39.75%   39.56%   -0.20%     
   ===========================================
     Files           50       50              
     Lines         2568     2626      +58     
   ===========================================
   + Hits          1021     1039      +18     
   - Misses        1436     1475      +39     
   - Partials       111      112       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/extension/adapter/adapter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vYWRhcHRlci9hZGFwdGVyLmdv) | `58.33% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `54.16% <0.00%> (-2.36%)` | :arrow_down: |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.18% <0.00%> (-0.14%)` | :arrow_down: |
   | [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `60.00% <0.00%> (-3.64%)` | :arrow_down: |
   | [pkg/server/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9waXhpdV9zdGFydC5nbw==) | `0.00% <ø> (ø)` | |
   | [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `45.45% <41.79%> (-22.84%)` | :arrow_down: |
   | [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `88.00% <100.00%> (-2.00%)` | :arrow_down: |
   | [pkg/server/adapter\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9hZGFwdGVyX21hbmFnZXIuZ28=) | `72.41% <100.00%> (+4.55%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e8add1...27f2a7f](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/255?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #255: Feat: Pixiu connect with SpringCloud Server by nacos

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #255:
URL: https://github.com/apache/dubbo-go-pixiu/pull/255


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org