You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Roger Meier (JIRA)" <ji...@apache.org> on 2011/06/24 14:37:47 UTC
[jira] [Commented] (THRIFT-1217) Use evutil_socketpair instead of
pipe (Windows port)
[ https://issues.apache.org/jira/browse/THRIFT-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054409#comment-13054409 ]
Roger Meier commented on THRIFT-1217:
-------------------------------------
I really like to have Windows port within next Thrift release. The suggestion by [David Reiss|https://issues.apache.org/jira/browse/THRIFT-1031?focusedCommentId=13014174&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13014174] and [me|https://issues.apache.org/jira/browse/THRIFT-1031?focusedCommentId=13016559&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13016559] to use APR on Windows and do minimal changes on the current implementation is a key factor to bring this up and running.
However, this patch depends on pthreads for windows and as mentioned on the dev mailing list or within Jira => it seems that this is not compatible with the apache license.
Is APR feasible for your?
Do you really need thet libevent version?
Most GNU/Linux distro still provide 1.4.x and I would really like to keep capability to build and use thrift without lot of extra versions of libraries not within a standard distribution.
> Use evutil_socketpair instead of pipe (Windows port)
> ----------------------------------------------------
>
> Key: THRIFT-1217
> URL: https://issues.apache.org/jira/browse/THRIFT-1217
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.6.1, 0.7
> Environment: Windows C++ 9.0, 10.0
> Reporter: alexandre parenteau
> Priority: Minor
> Labels: patch
> Fix For: 0.7
>
> Attachments: evutil_socketpair.txt
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> As part of an effort to use the Non-Blocking server (using libevent) on Windows, it was necessary to remove the use of "pipe" for the notification mechanism to signal end-of-task. We propose to use evutil_socketpair instead (tested with libevent 2.0.12). Patch included. Please see https://github.com/aubonbeurre/thrift/blob/alex-0.6.1/README.non.blocking.Windows for more details.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira