You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/07 07:33:39 UTC
[GitHub] [ignite-3] ibessonov opened a new pull request, #1417: IGNITE-18344 Missing .gitignore items
ibessonov opened a new pull request, #1417:
URL: https://github.com/apache/ignite-3/pull/1417
https://issues.apache.org/jira/browse/IGNITE-18344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] rpuch commented on a diff in pull request #1417: IGNITE-18344 Missing .gitignore items
Posted by GitBox <gi...@apache.org>.
rpuch commented on code in PR #1417:
URL: https://github.com/apache/ignite-3/pull/1417#discussion_r1041912974
##########
.gitignore:
##########
@@ -3,6 +3,9 @@ work
.DS_Store
.flattened-pom.xml
+**/generated
Review Comment:
After a build using IDEA (IDEA runner, not Gradle runner) in a project imported from Gradle build scripts, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on pull request #1417: IGNITE-18344 Missing .gitignore items
Posted by GitBox <gi...@apache.org>.
ibessonov commented on PR #1417:
URL: https://github.com/apache/ignite-3/pull/1417#issuecomment-1340664312
Re-qualified as a jvm crash dump ignore issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1417: IGNITE-18344 Missing .gitignore items
Posted by GitBox <gi...@apache.org>.
ibessonov commented on code in PR #1417:
URL: https://github.com/apache/ignite-3/pull/1417#discussion_r1041886757
##########
.gitignore:
##########
@@ -3,6 +3,9 @@ work
.DS_Store
.flattened-pom.xml
+**/generated
Review Comment:
No, it's about generated source in module directories. They appear after compilation using Gradle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov closed pull request #1417: IGNITE-18344 Missing .gitignore items
Posted by GitBox <gi...@apache.org>.
ibessonov closed pull request #1417: IGNITE-18344 Missing .gitignore items
URL: https://github.com/apache/ignite-3/pull/1417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on pull request #1417: IGNITE-18344 Missing .gitignore items
Posted by GitBox <gi...@apache.org>.
ibessonov commented on PR #1417:
URL: https://github.com/apache/ignite-3/pull/1417#issuecomment-1340662650
Configuring IDEA project with IDEA build process is, apparently, a bad idea. I'm closing the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov merged pull request #1417: IGNITE-18344 Missing .gitignore items
Posted by GitBox <gi...@apache.org>.
ibessonov merged PR #1417:
URL: https://github.com/apache/ignite-3/pull/1417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] rpuch commented on a diff in pull request #1417: IGNITE-18344 Missing .gitignore items
Posted by GitBox <gi...@apache.org>.
rpuch commented on code in PR #1417:
URL: https://github.com/apache/ignite-3/pull/1417#discussion_r1041883659
##########
.gitignore:
##########
@@ -3,6 +3,9 @@ work
.DS_Store
.flattened-pom.xml
+**/generated
Review Comment:
Is this about `build/generated`? If yes, it's already covered by the `build/` being ignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1417: IGNITE-18344 Missing .gitignore items
Posted by GitBox <gi...@apache.org>.
ibessonov commented on code in PR #1417:
URL: https://github.com/apache/ignite-3/pull/1417#discussion_r1041886757
##########
.gitignore:
##########
@@ -3,6 +3,9 @@ work
.DS_Store
.flattened-pom.xml
+**/generated
Review Comment:
No, it's about generated sources in module directories. They appear after compilation using Gradle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org