You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/21 03:18:51 UTC
[GitHub] [spark] maropu commented on a change in pull request #25214:
[SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of
the column
maropu commented on a change in pull request #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
URL: https://github.com/apache/spark/pull/25214#discussion_r305599966
##########
File path: sql/hive/src/test/resources/golden/decimal_4-6-693c2e345731f9b2b547c3b75218458e
##########
@@ -1,38 +1,38 @@
NULL 0
--1234567890.123456789 -1234567890
--4400 4400
--1255.49 -1255
--1.122 -11
--1.12 -1
--1.12 -1
--0.333 0
--0.33 0
--0.3 0
-0 0
-0 0
-0 0
-0.01 0
-0.02 0
-0.1 0
-0.2 0
-0.3 0
-0.33 0
-0.333 0
+-1234567890.1234567890000000000000000 -1234567890
+-4400.0000000000000000000000000 4400
+-1255.4900000000000000000000000 -1255
+-1.1220000000000000000000000 -11
+-1.1200000000000000000000000 -1
+-1.1200000000000000000000000 -1
+-0.3330000000000000000000000 0
+-0.3300000000000000000000000 0
+-0.3000000000000000000000000 0
+0.0000000000000000000000000 0
Review comment:
Thanks for the check!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org