You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by dcristoloveanu <gi...@git.apache.org> on 2015/07/08 02:22:19 UTC
[GitHub] qpid-proton pull request: -Fix 2 Code Analysis warnings and a real...
GitHub user dcristoloveanu opened a pull request:
https://github.com/apache/qpid-proton/pull/43
-Fix 2 Code Analysis warnings and a realloc failure
-Fix 2 Code Analysis warnings in iocp.c
-Fix one realloc leak and the fact that the realloc result was not checked. This rippled through codec.c as more functions needed to have error checking. Also, more fixes regarding return values being checked need to be done throughout message.c, transport.c, etc., but the amount of changes is significant, so it needs to be done in several chunks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dcristoloveanu/qpid-proton FixCodeAnalysis
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit a41bcbd6b48bc9a4507a844d4aa9ec1a37cec189
Author: dcristoloveanu <dc...@microsoft.com>
Date: 2015-07-08T00:18:05Z
-Fix 2 Code Analysis warnings in iocp.c
-Fix one realloc leak and the fact that the realloc result was not checked. This rippled through codec.c as more functions needed to have error checking. Also, more fixes regarding return values being checked need to be done throughout message.c, transport.c, etc., but the amount of changes is significant, so it needs to be done in several chunks.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: -Fix 2 Code Analysis warnings and a real...
Posted by dcristoloveanu <gi...@git.apache.org>.
Github user dcristoloveanu closed the pull request at:
https://github.com/apache/qpid-proton/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---