You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/11/07 01:10:32 UTC
[kudu-CR] docs: recommend memkind for NVM cache users
Hello Alexey Serbin, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14649
to review the following change.
Change subject: docs: recommend memkind for NVM cache users
......................................................................
docs: recommend memkind for NVM cache users
I intentionally omitted transitive dependencies; I assume that the memkind
package metadata properly expresses its own dependencies.
Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
---
M docs/installation.adoc
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/14649/1
--
To view, visit http://gerrit.cloudera.org:8080/14649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14649
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] docs: recommend memkind for NVM cache users
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14649 )
Change subject: docs: recommend memkind for NVM cache users
......................................................................
Patch Set 1:
Rendered version here: https://github.com/adembo/kudu/blob/docs/docs/installation.adoc
--
To view, visit http://gerrit.cloudera.org:8080/14649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14649
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 07 Nov 2019 01:10:50 +0000
Gerrit-HasComments: No
[kudu-CR] docs: recommend memkind for NVM cache users
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14649 )
Change subject: docs: recommend memkind for NVM cache users
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14649
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 07 Nov 2019 01:19:23 +0000
Gerrit-HasComments: No
[kudu-CR] docs: recommend memkind for NVM cache users
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14649 )
Change subject: docs: recommend memkind for NVM cache users
......................................................................
docs: recommend memkind for NVM cache users
I intentionally omitted transitive dependencies; I assume that the memkind
package metadata properly expresses its own dependencies.
Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Reviewed-on: http://gerrit.cloudera.org:8080/14649
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M docs/installation.adoc
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14649
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)