You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/09 17:54:43 UTC
[GitHub] [druid] ccaominh commented on a change in pull request #9339:
IntelliJ inspections cleanup
ccaominh commented on a change in pull request #9339: IntelliJ inspections cleanup
URL: https://github.com/apache/druid/pull/9339#discussion_r406375081
##########
File path: services/src/main/java/org/apache/druid/cli/CliHadoopIndexer.java
##########
@@ -84,8 +84,8 @@ public void run()
extensionURLs.addAll(Arrays.asList(((URLClassLoader) extensionLoader).getURLs()));
}
- final List<URL> nonHadoopURLs = new ArrayList<>();
- nonHadoopURLs.addAll(Arrays.asList(((URLClassLoader) CliHadoopIndexer.class.getClassLoader()).getURLs()));
+ final List<URL> nonHadoopURLs = new ArrayList<>(Arrays.asList(((URLClassLoader) CliHadoopIndexer.class.getClassLoader())
Review comment:
The `new ArrrayList<>()` seems unnecessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org