[GitHub] [incubator-heron] dnrusakov commented on a change in pull request #3282: WIP STREAMCOMP-2724: Stream Manager migrated to mainly use smart pointers instead of a manual memory management

[GitBox <gi...@apache.org>]

dnrusakov commented on a change in pull request #3282: WIP STREAMCOMP-2724: Stream Manager migrated to mainly use smart pointers instead of a manual memory management
URL: https://github.com/apache/incubator-heron/pull/3282#discussion_r291699370
 
 

 ##########
 File path: heron/instance/src/cpp/gateway/stmgr-client.cpp
 ##########
 @@ -97,32 +98,35 @@ void StMgrClient::HandleClose(NetworkErrorCode code) {
   AddTimer([this]() { this->OnReconnectTimer(); }, reconnect_interval_ * 1000 * 1000);
 }
 
-void StMgrClient::HandleRegisterResponse(void*, proto::stmgr::RegisterInstanceResponse* response,
-                                         NetworkErrorCode status) {
+void StMgrClient::HandleRegisterResponse(
+                                        void*,
 
 Review comment:
   Here and in other "indent" comments, if i align the indent, then the code in the line will hit the max line limit (100 chars) and, as a result, a compilation fails on a style-check step...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services