You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "vinothchandar (via GitHub)" <gi...@apache.org> on 2023/03/28 07:39:17 UTC
[GitHub] [hudi] vinothchandar commented on a diff in pull request #8304: [HUDI-5993] Connection leak for lock provider
vinothchandar commented on code in PR #8304:
URL: https://github.com/apache/hudi/pull/8304#discussion_r1150156757
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java:
##########
@@ -111,6 +111,7 @@ public void unlock() {
if (writeConfig.getWriteConcurrencyMode().supportsOptimisticConcurrencyControl()) {
getLockProvider().unlock();
metrics.updateLockHeldTimerMetrics();
+ close();
Review Comment:
Is this because we reuse the client ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org