[GitHub] [tinkerpop] spmallette opened a new pull request #1272: TINKERPOP-2345 Improved error message for bad value for math()

[GitBox <gi...@apache.org>]

spmallette opened a new pull request #1272: TINKERPOP-2345 Improved error message for bad value for math()
URL: https://github.com/apache/tinkerpop/pull/1272
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2345
   
   This problem really only applies to 3.4.x since by() didn't modulate Map traversers in 3.3.x. This change does also however fix the error message for non-Number objects trying to be passed into a math() expression, but the error is at least more understandable than the NullPointerException - on 3.3.x we get "java.lang.String cannot be cast to java.lang.Number" which while not perfect is probably good enough for that older version. It didn't seem like a big enough problem to add the enhancement there.
   
   All tests pass with `docker/build.sh -t -n -i`
   
   VOTE +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] spmallette merged pull request #1272: TINKERPOP-2345 Improved error message for bad value for math()

[GitBox <gi...@apache.org>]

spmallette merged pull request #1272: TINKERPOP-2345 Improved error message for bad value for math()
URL: https://github.com/apache/tinkerpop/pull/1272
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services