You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/11 18:57:59 UTC
[GitHub] [superset] AAfghahi commented on a diff in pull request #20281: feat: Visualize SqlLab.Query model data in Explore 📈
AAfghahi commented on code in PR #20281:
URL: https://github.com/apache/superset/pull/20281#discussion_r918256943
##########
superset-frontend/src/components/Chart/Chart.jsx:
##########
@@ -193,6 +202,17 @@ class Chart extends React.PureComponent {
});
}
+ getDatasourceAsSaveableDataset = source => {
Review Comment:
we repeat this pattern a couple of times, should we put it into utils?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org