[GitHub] [submarine] yuanzac commented on a change in pull request #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent

[GitBox <gi...@apache.org>]

yuanzac commented on a change in pull request #214: SUBMARINE-78. Make RemoteDirectoryManager interface more consistent
URL: https://github.com/apache/submarine/pull/214#discussion_r389785192
 
 

 ##########
 File path: submarine-commons/commons-runtime/src/main/java/org/apache/submarine/commons/runtime/fs/DefaultRemoteDirectoryManager.java
 ##########
 @@ -134,13 +134,13 @@ public boolean copyRemoteToLocal(String remoteUri, String localUri)
   }
 
   @Override
-  public boolean existsRemoteFile(Path url) throws IOException {
-    return getFileSystemByUri(url.toUri().toString()).exists(url);
+  public boolean existsRemoteFile(String remoteUri) throws IOException {
+    return getFileSystemByUri(remoteUri).exists(new Path(remoteUri));
   }
 
   @Override
-  public FileStatus getRemoteFileStatus(Path url) throws IOException {
-    return getFileSystemByUri(url.toUri().toString()).getFileStatus(url);
+  public FileStatus getRemoteFileStatus(String remoteUri) throws IOException {
 
 Review comment:
   We'd better use change getRemoteFileStatus(String remoteUri) to getRemoteFileStatus(String uri). So that the parameter name uri is the same as the one of the interface RemoteDirectoryManager

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org