You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Anand V Nath (JIRA)" <de...@myfaces.apache.org> on 2012/06/27 08:57:43 UTC

[jira] [Commented] (TRINIDAD-2172) pseudo classes missing from CSSGenerationUtils

    [ https://issues.apache.org/jira/browse/TRINIDAD-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402000#comment-13402000 ] 

Anand V Nath commented on TRINIDAD-2172:
----------------------------------------

Nested pseudo classes were not handled in the initial fix. Patch uploaded for handling this (jira-2172-not-pseudo-fix.patch)

Please reopen this bug and commit the patch.
                
> pseudo classes missing from CSSGenerationUtils
> ----------------------------------------------
>
>                 Key: TRINIDAD-2172
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2172
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Skinning
>    Affects Versions: 2.0.0-core
>            Reporter: Jeremy C. Hull
>            Assignee: Scott O'Bryan
>             Fix For: 2.0.1-core
>
>         Attachments: bug-13253267-3.patch, jira-2172-not-pseudo-fix.patch
>
>
> Only the following built-in pseudo classes are handled
>     _BUILT_IN_PSEUDO_CLASSES.add(":first-child");
>     _BUILT_IN_PSEUDO_CLASSES.add(":link");
>     _BUILT_IN_PSEUDO_CLASSES.add(":visited");
>     _BUILT_IN_PSEUDO_CLASSES.add(":hover");
>     _BUILT_IN_PSEUDO_CLASSES.add(":active");
>     _BUILT_IN_PSEUDO_CLASSES.add(":focus");
> There are a few CSS2.1 and a bunch of CSS3 pseudo classes that should be handled.
> first-letter, first-line, only-child, last-child, nth-child, nth-child-of-type, etc...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] [Commented] (TRINIDAD-2172) pseudo classes missing from CSSGenerationUtils

Posted by Anand Nath <an...@oracle.com>.
Hello,

Please review and commit the patch attached in the jira issue 
(jira-2172-not-pseudo-fix.patch).

Thanks
Anand

On 6/27/2012 1:34 PM, Anand Nath wrote:
> Hello,
>
> Please review and commit the patch attached in the jira issue 
> (jira-2172-not-pseudo-fix.patch).
>
> Thanks
> Anand
>
> On 6/27/2012 12:27 PM, Anand V Nath (JIRA) wrote:
>>      [ 
>> https://issues.apache.org/jira/browse/TRINIDAD-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402000#comment-13402000 
>> ]
>>
>> Anand V Nath commented on TRINIDAD-2172:
>> ----------------------------------------
>>
>> Nested pseudo classes were not handled in the initial fix. Patch 
>> uploaded for handling this (jira-2172-not-pseudo-fix.patch)
>>
>> Please reopen this bug and commit the patch.
>>
>>> pseudo classes missing from CSSGenerationUtils
>>> ----------------------------------------------
>>>
>>>                  Key: TRINIDAD-2172
>>>                  URL: 
>>> https://issues.apache.org/jira/browse/TRINIDAD-2172
>>>              Project: MyFaces Trinidad
>>>           Issue Type: Improvement
>>>           Components: Skinning
>>>     Affects Versions: 2.0.0-core
>>>             Reporter: Jeremy C. Hull
>>>             Assignee: Scott O'Bryan
>>>              Fix For: 2.0.1-core
>>>
>>>          Attachments: bug-13253267-3.patch, 
>>> jira-2172-not-pseudo-fix.patch
>>>
>>>
>>> Only the following built-in pseudo classes are handled
>>>      _BUILT_IN_PSEUDO_CLASSES.add(":first-child");
>>>      _BUILT_IN_PSEUDO_CLASSES.add(":link");
>>>      _BUILT_IN_PSEUDO_CLASSES.add(":visited");
>>>      _BUILT_IN_PSEUDO_CLASSES.add(":hover");
>>>      _BUILT_IN_PSEUDO_CLASSES.add(":active");
>>>      _BUILT_IN_PSEUDO_CLASSES.add(":focus");
>>> There are a few CSS2.1 and a bunch of CSS3 pseudo classes that 
>>> should be handled.
>>> first-letter, first-line, only-child, last-child, nth-child, 
>>> nth-child-of-type, etc...
>> -- 
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA 
>> administrators: 
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: 
>> http://www.atlassian.com/software/jira
>>
>>

Re: [jira] [Commented] (TRINIDAD-2172) pseudo classes missing from CSSGenerationUtils

Posted by Anand Nath <an...@oracle.com>.
Hello,

Please review and commit the patch attached in the jira issue 
(jira-2172-not-pseudo-fix.patch).

Thanks
Anand

On 6/27/2012 12:27 PM, Anand V Nath (JIRA) wrote:
>      [ https://issues.apache.org/jira/browse/TRINIDAD-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402000#comment-13402000 ]
>
> Anand V Nath commented on TRINIDAD-2172:
> ----------------------------------------
>
> Nested pseudo classes were not handled in the initial fix. Patch uploaded for handling this (jira-2172-not-pseudo-fix.patch)
>
> Please reopen this bug and commit the patch.
>
>> pseudo classes missing from CSSGenerationUtils
>> ----------------------------------------------
>>
>>                  Key: TRINIDAD-2172
>>                  URL: https://issues.apache.org/jira/browse/TRINIDAD-2172
>>              Project: MyFaces Trinidad
>>           Issue Type: Improvement
>>           Components: Skinning
>>     Affects Versions: 2.0.0-core
>>             Reporter: Jeremy C. Hull
>>             Assignee: Scott O'Bryan
>>              Fix For: 2.0.1-core
>>
>>          Attachments: bug-13253267-3.patch, jira-2172-not-pseudo-fix.patch
>>
>>
>> Only the following built-in pseudo classes are handled
>>      _BUILT_IN_PSEUDO_CLASSES.add(":first-child");
>>      _BUILT_IN_PSEUDO_CLASSES.add(":link");
>>      _BUILT_IN_PSEUDO_CLASSES.add(":visited");
>>      _BUILT_IN_PSEUDO_CLASSES.add(":hover");
>>      _BUILT_IN_PSEUDO_CLASSES.add(":active");
>>      _BUILT_IN_PSEUDO_CLASSES.add(":focus");
>> There are a few CSS2.1 and a bunch of CSS3 pseudo classes that should be handled.
>> first-letter, first-line, only-child, last-child, nth-child, nth-child-of-type, etc...
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>