You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/06/11 13:34:07 UTC
[GitHub] [tomcat] rotty3000 opened a new pull request #298: Fix BZ 64514 - classes missing from bootstrap.jar
rotty3000 opened a new pull request #298:
URL: https://github.com/apache/tomcat/pull/298
Signed-off-by: Raymond Augé <rotty3000@apache.org
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on pull request #298: Fix BZ 64514 - classes missing from bootstrap.jar
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #298:
URL: https://github.com/apache/tomcat/pull/298#issuecomment-642684919
So would you rather make the work around in the metadata calculation once/if we get that far? Personally I rather make a valid jar than work around the metadata but that's just personal preference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #298: Fix BZ 64514 - classes missing from bootstrap.jar
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #298:
URL: https://github.com/apache/tomcat/pull/298
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #298: Fix BZ 64514 - classes missing from bootstrap.jar
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #298:
URL: https://github.com/apache/tomcat/pull/298#issuecomment-642679912
I don't think this is correct. Only those classes required during the bootstrap process need to be in the bootstrap JAR. If this was not correct, I'd expect to see reports of ClassNotFoundException on Tomcat start and there aren't any.
Those classes may well have additional dependencies that are not used during the bootstrap process. Those dependencies do not belong in bootstrap.jar.
Taking ExceptionUtils as an example, there is an explicit workaround in Bootstrap to account for that class not being accessible.
For Globals, most (all?) of those will be constants which will be compiled into the class meaning there should be no runtime dependency on Globals.
And so on.
Unless you can provide a configuration that triggers a ClassNotFoundException on Tomcat start, I'm minded to resolve this as invalid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #298: Fix BZ 64514 - classes missing from bootstrap.jar
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #298:
URL: https://github.com/apache/tomcat/pull/298#issuecomment-644308328
Fixed via back-port (cherry-pick) of 10.0.x fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on pull request #298: Fix BZ 64514 - classes missing from bootstrap.jar
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #298:
URL: https://github.com/apache/tomcat/pull/298#issuecomment-642689875
From a JPMS point of view the goal is always that jdeps results match up with the module-info.class (i.e. that the jar is completely resolvable from the module path) and if you don't clear that you will always have to add a workaround to get the module-info you want (like adding a static module requires for the missing packages or forcing a manual ignore of the required module).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on pull request #298: Fix BZ 64514 - classes missing from bootstrap.jar
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #298:
URL: https://github.com/apache/tomcat/pull/298#issuecomment-642690642
For the record I'm more interested in establishing a baseline for how to handle these types of cases with the tomcat project. I will obviously follow your direction :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #298: Fix BZ 64514 - classes missing from bootstrap.jar
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #298:
URL: https://github.com/apache/tomcat/pull/298#issuecomment-642864883
There are trade-offs here.
Modules require "clean packages" with all code from one package in one JAR.
Bootstrap uses utility code from elsewhere in the Tomcat code base.
We want to keep the bootstrap JAR small.
We don't want to duplicate code.
Hmm...
This feels more like a discussion for the dev list. I'll move this discussion there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org