You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Jan Hentschel <ja...@ultratendency.com> on 2016/12/13 09:55:36 UTC
Review Request 54697: SENTRY-1513: Changed the way the split works
when parsing a path and corrected spelling in PathsUpdate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54697/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-1513
https://issues.apache.org/jira/browse/SENTRY-1513
Repository: sentry
Description
-------
Changed the way the split works when parsing a path and corrected spelling in PathsUpdate
Diffs
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java 7cfb3bf
Diff: https://reviews.apache.org/r/54697/diff/
Testing
-------
Thanks,
Jan Hentschel
Re: Review Request 54697: SENTRY-1513: Changed the way the split
works when parsing a path and corrected spelling in PathsUpdate
Posted by Jan Hentschel <ja...@ultratendency.com>.
> On Dec. 13, 2016, 6:58 p.m., Alexander Kolbasov wrote:
> > The change is fine, but the original JIRA was about the fact that we call split twice where we can split just once and save the result. The first time we split for the if statement, the second - to return the result.
Ok, good to know. Wasn't sure about that. Should I change the patch to the way you mentioned?
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54697/#review159031
-----------------------------------------------------------
On Dec. 13, 2016, 10:55 a.m., Jan Hentschel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54697/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 10:55 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1513
> https://issues.apache.org/jira/browse/SENTRY-1513
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Changed the way the split works when parsing a path and corrected spelling in PathsUpdate
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java 7cfb3bf
>
> Diff: https://reviews.apache.org/r/54697/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Hentschel
>
>
Re: Review Request 54697: SENTRY-1513: Changed the way the split
works when parsing a path and corrected spelling in PathsUpdate
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On Dec. 13, 2016, 5:58 p.m., Alexander Kolbasov wrote:
> > The change is fine, but the original JIRA was about the fact that we call split twice where we can split just once and save the result. The first time we split for the if statement, the second - to return the result.
>
> Jan Hentschel wrote:
> Ok, good to know. Wasn't sure about that. Should I change the patch to the way you mentioned?
That would be great since you are touching this code anyway.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54697/#review159031
-----------------------------------------------------------
On Dec. 13, 2016, 9:55 a.m., Jan Hentschel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54697/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 9:55 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1513
> https://issues.apache.org/jira/browse/SENTRY-1513
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Changed the way the split works when parsing a path and corrected spelling in PathsUpdate
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java 7cfb3bf
>
> Diff: https://reviews.apache.org/r/54697/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Hentschel
>
>
Re: Review Request 54697: SENTRY-1513: Changed the way the split
works when parsing a path and corrected spelling in PathsUpdate
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54697/#review159031
-----------------------------------------------------------
The change is fine, but the original JIRA was about the fact that we call split twice where we can split just once and save the result. The first time we split for the if statement, the second - to return the result.
- Alexander Kolbasov
On Dec. 13, 2016, 9:55 a.m., Jan Hentschel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54697/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 9:55 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1513
> https://issues.apache.org/jira/browse/SENTRY-1513
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Changed the way the split works when parsing a path and corrected spelling in PathsUpdate
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java 7cfb3bf
>
> Diff: https://reviews.apache.org/r/54697/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Hentschel
>
>
Re: Review Request 54697: SENTRY-1513: Changed the way the split
works when parsing a path and corrected spelling in PathsUpdate
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54697/#review159178
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On Dec. 13, 2016, 9:28 p.m., Jan Hentschel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54697/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 9:28 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1513
> https://issues.apache.org/jira/browse/SENTRY-1513
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Changed the way the split works when parsing a path and corrected spelling in PathsUpdate
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java 7cfb3bf
>
> Diff: https://reviews.apache.org/r/54697/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Hentschel
>
>
Re: Review Request 54697: SENTRY-1513: Changed the way the split
works when parsing a path and corrected spelling in PathsUpdate
Posted by Jan Hentschel <ja...@ultratendency.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54697/
-----------------------------------------------------------
(Updated Dec. 13, 2016, 10:28 p.m.)
Review request for sentry.
Changes
-------
Incorporated feedback provided by Alex.
Bugs: SENTRY-1513
https://issues.apache.org/jira/browse/SENTRY-1513
Repository: sentry
Description
-------
Changed the way the split works when parsing a path and corrected spelling in PathsUpdate
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java 7cfb3bf
Diff: https://reviews.apache.org/r/54697/diff/
Testing
-------
Thanks,
Jan Hentschel