You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/01/07 13:44:03 UTC
[GitHub] codecov-io commented on issue #245: SCB-159 Watcher will get a wrong event sequence when SC modify resource concurrently.
codecov-io commented on issue #245: SCB-159 Watcher will get a wrong event sequence when SC modify resource concurrently.
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/245#issuecomment-355823723
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/245?src=pr&el=h1) Report
> Merging [#245](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/245?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/008dbc7f02f8128933e835debed4de6ad587b214?src=pr&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/245?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
+ Coverage 68.78% 68.89% +0.11%
==========================================
Files 17 17
Lines 3556 3556
==========================================
+ Hits 2446 2450 +4
+ Misses 936 933 -3
+ Partials 174 173 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/245?src=pr&el=tree) | Coverage ? | |
|---|---|---|
| [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/245/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `49.71% <0%> (?)` | :arrow_up: |
| [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/245/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `73.83% <0%> (-0.59%)` | :arrow_down: |
| [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/245/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `76.06% <0%> (+0.42%)` | :arrow_up: |
| [server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/245/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==) | `73.63% <0%> (+0.78%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/245?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `? = absolute <relative> (impact)`, `? = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/245?src=pr&el=footer). Last update [008dbc7...8546418](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/245?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services