[jira] [Commented] (WAGON-448) Use Java String replace to avoid commons-lang dependency

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WAGON-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15080407#comment-15080407 ] 

ASF GitHub Bot commented on WAGON-448:
--------------------------------------

GitHub user CodingFabian opened a pull request:

    https://github.com/apache/maven-wagon/pull/20

    [WAGON-448] remove unnecessary dependency to commons-lang

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CodingFabian/maven-wagon WAGON-448

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-wagon/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20
    
----
commit d98f4eeb1fbc6f56d5cf7f040146f8c3f1025b98
Author: Fabian Lange <la...@gmail.com>
Date:   2016-01-03T11:42:31Z

    [WAGON-448] remove unnecessary dependency to commons-lang

----


> Use Java String replace to avoid commons-lang dependency
> --------------------------------------------------------
>
>                 Key: WAGON-448
>                 URL: https://issues.apache.org/jira/browse/WAGON-448
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-file
>            Reporter: Fabian Lange
>
> I am trying to reduce the amount of dependencies of the Apache Karaf project.
> One of the subcomponents uses wagon-http and wagon-file. By doing so, it receives a dependency to commons-lang.
> The reason is that wagon-file has a single use of StringUtils.replaceAll().
> https://github.com/apache/maven-wagon/blob/master/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java#L206
> This dependency can be easily avoided using the JDK util 
> {code}
> destinationPath.replace('\\', '/');
> {code}
> while this is also a bit faster, the main benefit is that we now can completely remove the lang dependency.
> Thank you!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)