[GitHub] [pinot] walterddr commented on a diff in pull request #8479: Use proto for query plan serialization

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #8479:
URL: https://github.com/apache/pinot/pull/8479#discussion_r845247951


##########
pinot-common/src/main/proto/plan.proto:
##########
@@ -0,0 +1,72 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+syntax = "proto3";
+
+package org.apache.pinot.common.proto;
+
+message StageNode {
+  int32 stageId = 1;
+  string nodeName = 2;
+  repeated StageNode inputs = 3;
+  ObjectFields fields = 4;
+}
+
+message ObjectFields {
+  map<string, LiteralField> literalField = 1;
+  map<string, ListField> listFields = 2;
+  map<string, MapField> mapFields = 3;
+}
+
+message LiteralField {
+  optional bool boolField = 1;
+  optional int32 intField = 2;
+  optional int64 longField = 3;
+  optional double doubleField = 4;
+  optional string stringField = 5;
+  optional bytes bytesField = 6;
+}

Review Comment:
   good catch. since oneof doesn't work with map field i forgot to add it elsewhere



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org