You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/03/22 18:28:40 UTC
[GitHub] [daffodil] tuxji opened a new pull request #777: Refresh sub-NOTICEs in bin.NOTICE
tuxji opened a new pull request #777:
URL: https://github.com/apache/daffodil/pull/777
Add sub-NOTICEs for these new transitive dependencies which
xmlresolver (Saxon-HE's new transitive dependency) depends on:
commons-codec.commons-codec-1.11.jar
commons-logging.commons-logging-1.2.jar
org.apache.httpcomponents.httpclient-4.5.13.jar
org.apache.httpcomponents.httpcore-4.4.13.jar
Also update some other sub-NOTICEs that had gotten out of date and
remove the line "This product includes software developed at The
Apache Software Foundation (https://www.apache.org/)" from sub-NOTICEs
since Apache instructions say it's redundant in sub-NOTICEs. While
we're at it, include even jars which have no sub-NOTICEs and reorder
all sub-NOTICEs by their jar name so we can compare the list in
bin.NOTICE to a listing of the lib directory to find new additions and
deletions more easily in the future.
DAFFODIL-2680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a change in pull request #777: Refresh sub-NOTICEs in bin.NOTICE
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on a change in pull request #777:
URL: https://github.com/apache/daffodil/pull/777#discussion_r835289294
##########
File path: daffodil-cli/bin.NOTICE
##########
@@ -11,118 +11,136 @@ Based on source code originally developed by
The following NOTICE information applies to binary components distributed with this project:
-Apache Commons IO (lib/commons-io.commons-io-<VERSION>.jar)
- Apache Commons IO
- Copyright 2002-2021 The Apache Software Foundation
+Jackson JSON processor (lib/com.fasterxml.jackson.core.jackson-core-<VERSION>.jar)
Review comment:
Why the change in order? This new ordering seems random to me? It also makes it hard to tell what's actually changed.
##########
File path: daffodil-cli/bin.NOTICE
##########
@@ -11,118 +11,136 @@ Based on source code originally developed by
The following NOTICE information applies to binary components distributed with this project:
-Apache Commons IO (lib/commons-io.commons-io-<VERSION>.jar)
- Apache Commons IO
- Copyright 2002-2021 The Apache Software Foundation
+Jackson JSON processor (lib/com.fasterxml.jackson.core.jackson-core-<VERSION>.jar)
+ # Jackson JSON processor
- This product includes software developed at
- The Apache Software Foundation (https://www.apache.org/).
+ Jackson is a high-performance, Free/Open Source JSON processing library.
+ It was originally written by Tatu Saloranta (tatu.saloranta@iki.fi), and has
+ been in development since 2007.
+ It is currently developed by a community of developers.
-Apache Log4j (lib/org.apache.logging.log4j.log4j-api-<VERSION>.jar, org.apache.logging.log4j.log4j-core-<VERSION>.jar)
- Apache Log4j
- Copyright 1999-2019 Apache Software Foundation
+ ## Licensing
- This product includes software developed at
- The Apache Software Foundation (http://www.apache.org/).
+ Jackson 2.x core and extension components are licensed under Apache License 2.0
+ To find the details that apply to this artifact see the accompanying LICENSE file.
- ResolverUtil.java
- Copyright 2005-2006 Tim Fennell
+ ## Credits
- Dumbster SMTP test server
- Copyright 2004 Jason Paul Kitchen
+ A list of contributors may be found from CREDITS(-2.x) file, which is included
+ in some artifacts (usually source distributions); but is always available
+ from the source code management (SCM) system project uses.
- TypeUtil.java
- Copyright 2002-2012 Ramnivas Laddad, Juergen Hoeller, Chris Beams
+Woodstox XML processor (lib/com.fasterxml.woodstox.woodstox-core-<VERSION>.jar)
+ [jar has no NOTICE]
Review comment:
It's not necessary to include things that don't have a notice. The goal is usually to keep this file as small as possible.
##########
File path: daffodil-cli/bin.NOTICE
##########
@@ -133,29 +151,88 @@ Scala (lib/org.scala-lang.scala-library-<VERSION>.jar)
and can be found in:
daffodil-lib/src/main/scala/org/apache/daffodil/util/UniquenessCache.scala
-Scala Parser Combinators (lib/org.scala-lang.modules.scala-parser-combinators_<VERSION>.jar)
- Scala parser combinators
+Scala Reflect (lib/org.scala-lang.scala-reflect-<REFLECT>.jar)
+ Scala
Copyright (c) 2002-2021 EPFL
Copyright (c) 2011-2021 Lightbend, Inc.
Scala includes software developed at
LAMP/EPFL (https://lamp.epfl.ch/) and
Lightbend, Inc. (https://www.lightbend.com/).
-Scala XML (lib/org.scala-lang.modules.scala-xml_<VERSION>.jar)
- scala-xml
- Copyright (c) 2002-2020 EPFL
- Copyright (c) 2011-2020 Lightbend, Inc.
+XML Resolver data (lib/org.xmlresolver.xmlresolver-<VERSION>-data.jar)
+ Schemas and documents from the W3C are being provided by the copyright
+ holders under the following license.
- scala-xml includes software developed at
- LAMP/EPFL (https://lamp.epfl.ch/) and
- Lightbend, Inc. (https://www.lightbend.com/).
+ License
Review comment:
I don't think this is NOTICE content, this is the actual [W3C license](https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document), it's just confusing since that license uses the word NOTICE. I think this belongs in the LICENSE.bin file.
##########
File path: daffodil-cli/bin.NOTICE
##########
@@ -11,118 +11,136 @@ Based on source code originally developed by
The following NOTICE information applies to binary components distributed with this project:
-Apache Commons IO (lib/commons-io.commons-io-<VERSION>.jar)
- Apache Commons IO
- Copyright 2002-2021 The Apache Software Foundation
+Jackson JSON processor (lib/com.fasterxml.jackson.core.jackson-core-<VERSION>.jar)
+ # Jackson JSON processor
- This product includes software developed at
- The Apache Software Foundation (https://www.apache.org/).
+ Jackson is a high-performance, Free/Open Source JSON processing library.
+ It was originally written by Tatu Saloranta (tatu.saloranta@iki.fi), and has
+ been in development since 2007.
+ It is currently developed by a community of developers.
-Apache Log4j (lib/org.apache.logging.log4j.log4j-api-<VERSION>.jar, org.apache.logging.log4j.log4j-core-<VERSION>.jar)
- Apache Log4j
- Copyright 1999-2019 Apache Software Foundation
+ ## Licensing
- This product includes software developed at
- The Apache Software Foundation (http://www.apache.org/).
+ Jackson 2.x core and extension components are licensed under Apache License 2.0
+ To find the details that apply to this artifact see the accompanying LICENSE file.
- ResolverUtil.java
- Copyright 2005-2006 Tim Fennell
+ ## Credits
- Dumbster SMTP test server
- Copyright 2004 Jason Paul Kitchen
+ A list of contributors may be found from CREDITS(-2.x) file, which is included
+ in some artifacts (usually source distributions); but is always available
+ from the source code management (SCM) system project uses.
- TypeUtil.java
- Copyright 2002-2012 Ramnivas Laddad, Juergen Hoeller, Chris Beams
+Woodstox XML processor (lib/com.fasterxml.woodstox.woodstox-core-<VERSION>.jar)
+ [jar has no NOTICE]
- picocli (http://picocli.info)
- Copyright 2017 Remko Popma
+International Components for Unicode for Java (lib/com.ibm.icu.icu4j-<VERSION>.jar)
Review comment:
Even though that's what it stands for, I think the name is still ICU4J. But I don't think it really matters since we don't need this in here since there's no NOTICE file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a change in pull request #777: Refresh sub-NOTICEs in bin.NOTICE
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on a change in pull request #777:
URL: https://github.com/apache/daffodil/pull/777#discussion_r836377402
##########
File path: daffodil-cli/bin.NOTICE
##########
@@ -11,118 +11,136 @@ Based on source code originally developed by
The following NOTICE information applies to binary components distributed with this project:
-Apache Commons IO (lib/commons-io.commons-io-<VERSION>.jar)
- Apache Commons IO
- Copyright 2002-2021 The Apache Software Foundation
+Jackson JSON processor (lib/com.fasterxml.jackson.core.jackson-core-<VERSION>.jar)
+ # Jackson JSON processor
- This product includes software developed at
- The Apache Software Foundation (https://www.apache.org/).
+ Jackson is a high-performance, Free/Open Source JSON processing library.
+ It was originally written by Tatu Saloranta (tatu.saloranta@iki.fi), and has
+ been in development since 2007.
+ It is currently developed by a community of developers.
-Apache Log4j (lib/org.apache.logging.log4j.log4j-api-<VERSION>.jar, org.apache.logging.log4j.log4j-core-<VERSION>.jar)
- Apache Log4j
- Copyright 1999-2019 Apache Software Foundation
+ ## Licensing
- This product includes software developed at
- The Apache Software Foundation (http://www.apache.org/).
+ Jackson 2.x core and extension components are licensed under Apache License 2.0
+ To find the details that apply to this artifact see the accompanying LICENSE file.
- ResolverUtil.java
- Copyright 2005-2006 Tim Fennell
+ ## Credits
- Dumbster SMTP test server
- Copyright 2004 Jason Paul Kitchen
+ A list of contributors may be found from CREDITS(-2.x) file, which is included
+ in some artifacts (usually source distributions); but is always available
+ from the source code management (SCM) system project uses.
- TypeUtil.java
- Copyright 2002-2012 Ramnivas Laddad, Juergen Hoeller, Chris Beams
+Woodstox XML processor (lib/com.fasterxml.woodstox.woodstox-core-<VERSION>.jar)
+ [jar has no NOTICE]
Review comment:
I'd suggest we have another way to track which jars don't have notices. Back when we were in the incubator we were dinged multiple times for including non-NOTICE things in the NOTICE file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji merged pull request #777: Refresh sub-NOTICEs in bin.NOTICE
Posted by GitBox <gi...@apache.org>.
tuxji merged pull request #777:
URL: https://github.com/apache/daffodil/pull/777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji commented on a change in pull request #777: Refresh sub-NOTICEs in bin.NOTICE
Posted by GitBox <gi...@apache.org>.
tuxji commented on a change in pull request #777:
URL: https://github.com/apache/daffodil/pull/777#discussion_r835420820
##########
File path: daffodil-cli/bin.NOTICE
##########
@@ -11,118 +11,136 @@ Based on source code originally developed by
The following NOTICE information applies to binary components distributed with this project:
-Apache Commons IO (lib/commons-io.commons-io-<VERSION>.jar)
- Apache Commons IO
- Copyright 2002-2021 The Apache Software Foundation
+Jackson JSON processor (lib/com.fasterxml.jackson.core.jackson-core-<VERSION>.jar)
Review comment:
The new ordering isn't random. Rather, it reorders all the sub-NOTICEs by their jar name so all the sub-NOTICEs are in the same order as a listing of the jars in the lib directory. This serves three purposes: 1) we can notice immediately when new jars haven't been added to the sub-NOTICEs yet; 2) we know unambiguously where to insert new sub-NOTICEs to keep them ordered by jar name; and 2) we can methodically go through an Emacs dired buffer listing the jars in the lib directory, look inside every jar, and update the sub-NOTICEs if we do miss some changes since the majority of jars already have NOTICE files packaged inside the jars.
##########
File path: daffodil-cli/bin.NOTICE
##########
@@ -11,118 +11,136 @@ Based on source code originally developed by
The following NOTICE information applies to binary components distributed with this project:
-Apache Commons IO (lib/commons-io.commons-io-<VERSION>.jar)
- Apache Commons IO
- Copyright 2002-2021 The Apache Software Foundation
+Jackson JSON processor (lib/com.fasterxml.jackson.core.jackson-core-<VERSION>.jar)
+ # Jackson JSON processor
- This product includes software developed at
- The Apache Software Foundation (https://www.apache.org/).
+ Jackson is a high-performance, Free/Open Source JSON processing library.
+ It was originally written by Tatu Saloranta (tatu.saloranta@iki.fi), and has
+ been in development since 2007.
+ It is currently developed by a community of developers.
-Apache Log4j (lib/org.apache.logging.log4j.log4j-api-<VERSION>.jar, org.apache.logging.log4j.log4j-core-<VERSION>.jar)
- Apache Log4j
- Copyright 1999-2019 Apache Software Foundation
+ ## Licensing
- This product includes software developed at
- The Apache Software Foundation (http://www.apache.org/).
+ Jackson 2.x core and extension components are licensed under Apache License 2.0
+ To find the details that apply to this artifact see the accompanying LICENSE file.
- ResolverUtil.java
- Copyright 2005-2006 Tim Fennell
+ ## Credits
- Dumbster SMTP test server
- Copyright 2004 Jason Paul Kitchen
+ A list of contributors may be found from CREDITS(-2.x) file, which is included
+ in some artifacts (usually source distributions); but is always available
+ from the source code management (SCM) system project uses.
- TypeUtil.java
- Copyright 2002-2012 Ramnivas Laddad, Juergen Hoeller, Chris Beams
+Woodstox XML processor (lib/com.fasterxml.woodstox.woodstox-core-<VERSION>.jar)
+ [jar has no NOTICE]
Review comment:
If we include even jars that don't have a NOTICE, we will notice immediately when new jars haven't been added to the sub-NOTICEs yet. We also won't keep looking inside jars that we know don't have a NOTICE inside them (unless their versions have been bumped, in which case we look inside them again just in case).
##########
File path: daffodil-cli/bin.NOTICE
##########
@@ -11,118 +11,136 @@ Based on source code originally developed by
The following NOTICE information applies to binary components distributed with this project:
-Apache Commons IO (lib/commons-io.commons-io-<VERSION>.jar)
- Apache Commons IO
- Copyright 2002-2021 The Apache Software Foundation
+Jackson JSON processor (lib/com.fasterxml.jackson.core.jackson-core-<VERSION>.jar)
+ # Jackson JSON processor
- This product includes software developed at
- The Apache Software Foundation (https://www.apache.org/).
+ Jackson is a high-performance, Free/Open Source JSON processing library.
+ It was originally written by Tatu Saloranta (tatu.saloranta@iki.fi), and has
+ been in development since 2007.
+ It is currently developed by a community of developers.
-Apache Log4j (lib/org.apache.logging.log4j.log4j-api-<VERSION>.jar, org.apache.logging.log4j.log4j-core-<VERSION>.jar)
- Apache Log4j
- Copyright 1999-2019 Apache Software Foundation
+ ## Licensing
- This product includes software developed at
- The Apache Software Foundation (http://www.apache.org/).
+ Jackson 2.x core and extension components are licensed under Apache License 2.0
+ To find the details that apply to this artifact see the accompanying LICENSE file.
- ResolverUtil.java
- Copyright 2005-2006 Tim Fennell
+ ## Credits
- Dumbster SMTP test server
- Copyright 2004 Jason Paul Kitchen
+ A list of contributors may be found from CREDITS(-2.x) file, which is included
+ in some artifacts (usually source distributions); but is always available
+ from the source code management (SCM) system project uses.
- TypeUtil.java
- Copyright 2002-2012 Ramnivas Laddad, Juergen Hoeller, Chris Beams
+Woodstox XML processor (lib/com.fasterxml.woodstox.woodstox-core-<VERSION>.jar)
+ [jar has no NOTICE]
- picocli (http://picocli.info)
- Copyright 2017 Remko Popma
+International Components for Unicode for Java (lib/com.ibm.icu.icu4j-<VERSION>.jar)
Review comment:
I looked inside the jar's MANIFEST.MF, found that long name, copied it, and used that long name to match what the jar calls itself. Simple, yes?
##########
File path: daffodil-cli/bin.NOTICE
##########
@@ -133,29 +151,88 @@ Scala (lib/org.scala-lang.scala-library-<VERSION>.jar)
and can be found in:
daffodil-lib/src/main/scala/org/apache/daffodil/util/UniquenessCache.scala
-Scala Parser Combinators (lib/org.scala-lang.modules.scala-parser-combinators_<VERSION>.jar)
- Scala parser combinators
+Scala Reflect (lib/org.scala-lang.scala-reflect-<REFLECT>.jar)
+ Scala
Copyright (c) 2002-2021 EPFL
Copyright (c) 2011-2021 Lightbend, Inc.
Scala includes software developed at
LAMP/EPFL (https://lamp.epfl.ch/) and
Lightbend, Inc. (https://www.lightbend.com/).
-Scala XML (lib/org.scala-lang.modules.scala-xml_<VERSION>.jar)
- scala-xml
- Copyright (c) 2002-2020 EPFL
- Copyright (c) 2011-2020 Lightbend, Inc.
+XML Resolver data (lib/org.xmlresolver.xmlresolver-<VERSION>-data.jar)
+ Schemas and documents from the W3C are being provided by the copyright
+ holders under the following license.
- scala-xml includes software developed at
- LAMP/EPFL (https://lamp.epfl.ch/) and
- Lightbend, Inc. (https://www.lightbend.com/).
+ License
Review comment:
Oh, you're right. I saw the path `org/xmlresolver/notices/w3c-license.txt` inside the jar and thought it was a NOTICE due to the folder's name. I've just pushed another commit removing the license text from here and adding the jar's name to the list of files under the W3C license in bin.LICENSE file. With that change made, do you approve continuing to list all the jars here (even jars with no NOTICEs)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org