You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by laimis <gi...@git.apache.org> on 2015/02/01 12:38:13 UTC
[GitHub] lucenenet pull request: Support negative numbers in Lucene40 codec
GitHub user laimis opened a pull request:
https://github.com/apache/lucenenet/pull/67
Support negative numbers in Lucene40 codec
Lucene40 codec picks different methods of storing numeric values based on what data type is large enough to represent them. The issue was with the numbers that can fit in sbyte, they were being returned as byte due to our migration. Negative numbers -128 or greater were being returned as positive numbers.
This passes all remaining failing Lucene40 codec tests. Here is one example:
http://teamcity.codebetter.com/viewLog.html?buildId=180212&tab=buildResultsDiv&buildTypeId=LuceneNet_Core#testNameId-8934306368705483624
Test expects to get back -10 but is getting back 246 instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laimis/lucenenet lucene40docvaluesreader_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit f300a4de6efbedd709b44f1b42a358398fbfd1cb
Author: Laimonas Simutis <la...@gmail.com>
Date: 2015-02-01T11:26:09Z
support negative numbers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: Support negative numbers in Lucene40 codec
Posted by laimis <gi...@git.apache.org>.
Github user laimis commented on the pull request:
https://github.com/apache/lucenenet/pull/67#issuecomment-72362669
@synhershko are you sure you are running fully compiled after merging my changes? In TC builds and several local builds that test case passes as expected. Make sure you did a full rebuild if you ran it locally after merging my changes, that has gotten me before.
The sbyte that you added will not make a difference because the header value is either 0 or 1 value, works in byte and sbyte format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: Support negative numbers in Lucene40 codec
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucenenet/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: Support negative numbers in Lucene40 codec
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/67#issuecomment-72362242
FYI Lucene.Net.Index.BaseDocValuesFormatTestCase.TestTwoDocumentsMerged() still fails
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: Support negative numbers in Lucene40 codec
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/67#issuecomment-72361695
There's some more such places, I'm on it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: Support negative numbers in Lucene40 codec
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/67#issuecomment-72362825
Yes, works now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---