You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by motorro <gi...@git.apache.org> on 2014/07/20 18:39:53 UTC
[GitHub] cordova-lib pull request: Maintain plugin preferencies
GitHub user motorro opened a pull request:
https://github.com/apache/cordova-lib/pull/63
Maintain plugin preferencies
A fullfilled feature [CB-7142](https://issues.apache.org/jira/browse/CB-7142)
Supports:
* Maintaining plugin installation URL in config feature list to be able to restore with `cordova restore plugins`
* Maintaining plugin preferences in config feature list. Otherwize the plugin like [this](https://github.com/EddyVerbruggen/LaunchMyApp-PhoneGap-Plugin) fail to restore or be added after `cordova platform add` command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/motorro/cordova-lib maintain-plugin-preferencies
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/63.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #63
----
commit 4c5765404ed8714a5ea0f8d5e026d3280335405d
Author: motorro <mo...@gmail.com>
Date: 2014-07-16T01:43:36Z
Restoring plugin preferences and installation url from config.xml
commit 7492b0a3c6893dddba4790da8b1e103ce4672bc2
Author: motorro <mo...@gmail.com>
Date: 2014-07-19T01:24:12Z
Parsing features data
commit 0fd5f39baaa9d4fae1d8b6df841fcbba78e5d34f
Author: motorro <mo...@gmail.com>
Date: 2014-07-20T15:22:23Z
ConfigParser specs for getting feature id list and getting feature data
commit 83b5e4366f4d15f160133fe3d39627fbe189e83d
Author: motorro <mo...@gmail.com>
Date: 2014-07-20T15:49:26Z
Feature preferences are passed to plugman when installing plugins after platform add
commit 60b16840cf6bd8e49df38aa2439d9373da1127cc
Author: motorro <mo...@gmail.com>
Date: 2014-07-20T16:23:55Z
Restoring plugins along with their preferences
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: Maintain plugin preferencies
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/63
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: Maintain plugin preferencies
Posted by motorro <gi...@git.apache.org>.
Github user motorro commented on the pull request:
https://github.com/apache/cordova-lib/pull/63#issuecomment-52412436
@agrieve
Done with ICLA and dev-list introduction :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: Maintain plugin preferencies
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/63#issuecomment-52344620
Just getting back to this. Code looks good!
Before we can merge it though, you need to sign Apache's Contributor License Agreement (can be done online): http://www.apache.org/licenses/#clas
Let me know when this is done and I'll merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---