You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2016/01/08 17:34:58 UTC

svn commit: r1723755 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java

Author: tilman
Date: Fri Jan  8 16:34:58 2016
New Revision: 1723755

URL: http://svn.apache.org/viewvc?rev=1723755&view=rev
Log:
PDFBOX-2852: DRY refactoring

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java?rev=1723755&r1=1723754&r2=1723755&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java Fri Jan  8 16:34:58 2016
@@ -478,15 +478,7 @@ public class PDPageTree implements COSOb
         {
             throw new IllegalArgumentException("attempted to insert before orphan page");
         }
-
-        // now increase every parent
-        do
-        {
-            int cnt = parentDict.getInt(COSName.COUNT);
-            parentDict.setInt(COSName.COUNT, cnt + 1);
-            parentDict = (COSDictionary) parentDict.getDictionaryObject(COSName.PARENT);
-        }
-        while (parentDict != null);
+        increaseParents(parentDict);
     }
 
     /**
@@ -518,8 +510,11 @@ public class PDPageTree implements COSOb
         {
             throw new IllegalArgumentException("attempted to insert before orphan page");
         }
+        increaseParents(parentDict);
+    }
 
-        // now increase every parent
+    private void increaseParents(COSDictionary parentDict)
+    {
         do
         {
             int cnt = parentDict.getInt(COSName.COUNT);