You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "eric-maynard (via GitHub)" <gi...@apache.org> on 2025/03/04 22:45:29 UTC
[PR] Add Identifier annotation to DefaultActiveRolesProvider [polaris]
eric-maynard opened a new pull request, #1111:
URL: https://github.com/apache/polaris/pull/1111
When debugging with Quarkus, @RichardLiu2001 and I noticed that `DefaultActiveRolesProvider` doesn't have an `Identifier` currently. This means that if we add a new implementation of `ActiveRolesProvider`, the runtime can fail with:
```
jakarta.enterprise.inject.AmbiguousResolutionException: Ambiguous dependencies for type org.apache.polaris.service.auth.ActiveRolesProvider and qualifiers [@Default]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Identifier annotation to DefaultActiveRolesProvider [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #1111:
URL: https://github.com/apache/polaris/pull/1111#issuecomment-2699763331
Good catch @dimas-b, did you mean something like [this](https://github.com/apache/polaris/pull/1111/commits/97d6201d0b804c5bfdbfb99f45e4f5e75173edcb)?
What I see now when running `QuarkusProducers` is:
```
System property not set correctly: quarkus.http.test-port
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Identifier annotation to DefaultActiveRolesProvider [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #1111:
URL: https://github.com/apache/polaris/pull/1111#issuecomment-2701861445
> System property not set correctly: quarkus.http.test-port
This is usually an indicator that the server did not start for some reason... The root cause may be hidden in logs (especially if they are redirected).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Identifier annotation to DefaultActiveRolesProvider [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #1111:
URL: https://github.com/apache/polaris/pull/1111#issuecomment-2699339319
My mistake, as CI shows the change is not innoccuous :sweat_smile:
```
UnsatisfiedResolutionException: Unsatisfied dependency for type org.apache.polaris.service.auth.ActiveRolesProvider and qualifiers [@Default]
```
This can be resolved by adding a custom producer method similar to this: https://github.com/apache/polaris/blob/3816cfda02cf145a1ef35a2c4990203137098e26/quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java#L43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Identifier annotation to DefaultActiveRolesProvider [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1111:
URL: https://github.com/apache/polaris/pull/1111#discussion_r1980612811
##########
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##########
@@ -239,6 +241,13 @@ public PolarisEntityManager polarisEntityManager(
return new PolarisEntityManager(polarisMetaStoreManager, credentialCache, entityCache);
}
+ @Produces
+ public ActiveRolesProvider activeRolesProvider(
+ @ConfigProperty(name = "quarkus.active-roles-provider.type") String persistenceType,
Review Comment:
We probably need to set this config in `application.properties` to `default`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Identifier annotation to DefaultActiveRolesProvider [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard merged PR #1111:
URL: https://github.com/apache/polaris/pull/1111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org