You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/06 15:25:49 UTC

[GitHub] [cloudstack] neogismm commented on a diff in pull request #6524: [GSOC] Oauth2 google idp

neogismm commented on code in PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#discussion_r963849159


##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -20,4 +20,112 @@
 --;
 
 UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
-UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
\ No newline at end of file
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
+

Review Comment:
   Rebasing the branch and pushing brings changes from all authors including my own changes.
   My changes are reserved for plugins/user-authenticators/oauth2.
   I know this is not the right way to push my code, can you suggest how to do it the right way?
   Maybe I'll create a new PR with only my changes and close this one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org